Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to Add Reminders to Events #87

Closed
davidmyers-a opened this issue May 26, 2020 · 2 comments · Fixed by #126
Closed

Ability to Add Reminders to Events #87

davidmyers-a opened this issue May 26, 2020 · 2 comments · Fixed by #126
Labels
feature new feature request

Comments

@davidmyers-a
Copy link

Would it be possible to update the library to add alarms for ICalendar events?

Curently in ICalendar.js if i add the below code in it will hardcode an alarm for the event 10minutes before the time of the event. Not sure if you wanted to add support for this in the library via the constructor, if so it would be a nice feature.

      event.join('\n'),
      ...
      'BEGIN:VALARM',
      'TRIGGER:-P0DT0H10M0S',
      'ACTION:DISPLAY',
      `DESCRIPTION:${description}`,
      'END:VALARM',
      ...
      'END:VEVENT',      
@jshor
Copy link
Owner

jshor commented May 26, 2020

I plan to add alarms to this library, although the fundamental usage would have to change. ICS would be the only one to support it, so there would no longer be a common config object.

@jshor jshor added the feature new feature request label May 26, 2020
@jshor
Copy link
Owner

jshor commented Oct 20, 2020

This feature will be implemented in V6 (PR #126), which will be released this week.

Following your example, the usage for addAlarm() would be:

calendar
  .addAlarm({
    description: description
    trigger: {
      minutes: 10
    }
  })

There will also be a method, addProperty(), which will allow you to add other ICS properties that are not already defined by Datebook:

calendar
  .addProperty('CATEGORIES', 'MEETINGS,MANAGEMENT')

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature new feature request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants