application/json should have utf-8 charset

[jonathanong]

because why not

[dougwilson]

exactly "because why not" is how I see it :D

[Fishrock123]

We should probably let the user define the implied charset. (with fallback to UTF-8)

As for setting it, /text|json|javascript/ could work as a start.

Though it omits a lot. Specifically xml types. But we cannot guarantee that a type that has "xml" in it will have a sane charset.

[jonathanong]

what do you mean? users should only be using .lookup() if a charset isn't defined. i.e. look at contentType()

[jonathanong]

oh yeah we should include javascript as well... because why not

[Fishrock123]

@jonathanong I mean users should be able to set the global charset for this module. (defaulting to UTF-8)

[jonathanong]

meh when would anyone use taht though?

[dougwilson]

We should probably let the user define the implied charset.

It's probably dubious, since they'd really need to be using Buffers everywhere and iconv so their generated responses are actually in the correct byte format. (i.e. they probably aren't and as such are sending UTF-8 bytes).

[Fishrock123]

Oh, eh. Whatever. Not using UTF-8 is pretty much nonsense anyways.

[Fishrock123]

Anyways; the issue landed in 48855cd

I'll think about /text|json|javascript/.

[jonathanong]

yeah, i dunno about js. i think we should wait until people open up charset issues before adding additional special cases.