rtnetlink: complete route multipath encoding and decoding logic #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdlayher
force-pushed
the
mdl-multipath
branch
from
94bb867
to
2ee9c0b
Compare
|
This needs to be fuzzed for sure. |
Signed-off-by: Dave Josephsen <djosephsen@fastly.com> Signed-off-by: Matt Layher <mlayher@fastly.com>
mdlayher
force-pushed
the
mdl-multipath
branch
from
2ee9c0b
to
bae8079
Compare
|
Looking good. Will you be taking care of the Length field (as mentioned in the TODO) in this PR or later? |
jsimonetti
approved these changes
Oct 26, 2020
I'll start a fuzz run tomorrow and commit new corpus in a seperate PR |
|
Looks like the encoding TODO you mention is already done actually! This both encodes and decodes successfully. Thanks for offering to fuzz, I'll be doing that soon as well. I can already spot a couple of places where I suspect there will be problems. I'll merge for now and do more cleanup in subsequent PRs because it's been a bit of a nuisance to keep this branch updated. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored by @djosephsen, and supersedes #82. Will squash on approval.
I've tested this successfully in an environment using multipath nexthop attributes.