Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jsk_data][download_data.py] chmod decompressed data #1532

Merged
merged 1 commit into from
Jun 26, 2017

Conversation

furushchev
Copy link
Member

Major Update

  • Change permission of not only downloaded data but also decompressed data

Minor fix

  • Fix: ZipFile does not have a method getnames

@furushchev furushchev requested a review from wkentaro June 20, 2017 16:57
@wkentaro
Copy link
Member

Why not remove it?

@furushchev
Copy link
Member Author

furushchev commented Jun 20, 2017 via email

@furushchev
Copy link
Member Author

@wkentaro Test passed. Please review.

@wkentaro
Copy link
Member

wkentaro commented Jun 21, 2017

I meant removing *.orig.bag. I didn't notice that you also do decompressing *.zip or *.tgz, and it cannot be removed.

@k-okada k-okada merged commit f5f6d2d into jsk-ros-pkg:master Jun 26, 2017
@furushchev furushchev deleted the chmod-decompress branch November 2, 2017 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants