Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jsk_topic_tools: add stealth_relay for silently subscribing topic #1544

Merged
merged 2 commits into from
Aug 30, 2017
Merged

jsk_topic_tools: add stealth_relay for silently subscribing topic #1544

merged 2 commits into from
Aug 30, 2017

Conversation

furushchev
Copy link
Member

@furushchev furushchev commented Aug 9, 2017 •
edited
Loading

This node relays topic from ~input and ~output as normal rostopic relay, but it does not increment number of subscribers (actually increments number of subscribers, but not looks like so)

@snozawa
Copy link
Contributor

snozawa commented Aug 11, 2017

👍

k-okada
k-okada requested changes Aug 11, 2017
View reviewed changes
Copy link
Member

@k-okada k-okada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. send feature requests to upstream
  2. add doc
  3. add sample

@furushchev
Copy link
Member Author

furushchev commented Aug 28, 2017 •
edited
Loading

@furushchev
Copy link
Member Author

@k-okada Now changed following your review! 👍

@k-okada k-okada merged commit 24a7d98 into jsk-ros-pkg:master Aug 30, 2017
@furushchev furushchev mentioned this pull request Aug 31, 2017
Merged
@furushchev furushchev deleted the stealth-relay branch October 7, 2017 01:35
@furushchev furushchev added this to the 2.2.6 milestone Oct 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k-okada k-okada k-okada requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.2.6
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@furushchev @snozawa @k-okada