Validate implementation of child class of ConnectionBasedTransport #1556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Someone use this class without any subscriptions, and in that case this class should not be used in general.
wkentaro
changed the title
pazeshun
approved these changes
Aug 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This checks some common mistakes when users implement Python node using
jsk_topic_tools.ConnectionBasedTransport.Check if publishers exist to avoid implementation failures
Someone uses rospy.Publisher instead of ConnectionBasedTransport.advertise.
Use ABCMeta to avoid unexpected usage of ConnectionBasedTransport
Someone uses this class without any subscriptions, and in that case this
class should not be used in general. ABCMeta forces user to overwrite the abstract methods (ex.
subscribe,unsubscribe).