Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix roscore regardless #1576

Merged
merged 3 commits into from
Jan 15, 2018
Merged

Conversation

furushchev
Copy link
Member

  • jsk_topic_tools: isMasterAlive was not working correctly.
  • jsk_tools: roscore_regardless.py
    • Added feature to pass signals sent to parent to children
    • Set proper attributes on spawn child process
    • Clean and quiet log printing
    • Killing by gradually escalating signals like roslaunch

@k-okada k-okada merged commit 431335a into jsk-ros-pkg:master Jan 15, 2018
@furushchev furushchev deleted the fix-roscore-regardless branch January 17, 2018 01:03
@mmurooka
Copy link
Member

@furushchev
I might heard from you before that some update is necessary in the following use of roscore_regardless (maybe something about respawn?) after this PR is merged, but I forgot that. Do you remember that?
https://github.com/start-jsk/rtmros_hrp2/blob/master/jsk_hrp2_ros_bridge/scripts/hrp2_stat.sh#L13

@furushchev
Copy link
Member Author

@mmurooka Yes, previously a target node is respawned by default, which is now disabled.
If you want to enable respawning target node, I provide an option --respawn or -r for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants