Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add latch argument to advetiseImage and advertiseCamera #1673

Merged
merged 3 commits into from
Dec 28, 2020

Conversation

garaemon
Copy link
Member

  • Add latch argument to advetiseImage and advertiseCamera instead of
    reading latch parameter from ros server in order to set different latch
    parameter for each publisher in one nodelet.

* Add latch argument to advetiseImage and advertiseCamera instead of
  reading latch parameter from ros server in order to set different latch
  parameter for each publisher in one nodelet.
@k-okada
Copy link
Member

k-okada commented Dec 28, 2020

@garaemon thank you, may be you need to change variabel name.

Errors << jsk_topic_tools:make /home/travis/ros/ws_jsk_common/logs/jsk_topic_tools/build.make.000.log
In file included from /home/travis/ros/ws_jsk_common/src/jsk_common/jsk_topic_tools/src/connection_based_nodelet.cpp:37:0:
/home/travis/ros/ws_jsk_common/src/jsk_common/jsk_topic_tools/include/jsk_topic_tools/connection_based_nodelet.h: In member function 'image_transport::CameraPublisher jsk_topic_tools::ConnectionBasedNodelet::advertiseCamera(ros::NodeHandle&, const string&, int, bool)':
/home/travis/ros/ws_jsk_common/src/jsk_common/jsk_topic_tools/include/jsk_topic_tools/connection_based_nodelet.h:317:12: error: declaration of 'bool latch' shadows a parameter
       bool latch;
            ^
make[2]: *** [CMakeFiles/jsk_topic_tools.dir/src/connection_based_nodelet.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs...

@garaemon
Copy link
Member Author

@k-okada Thanks, I fixed it.

And I added the new advertise method which exposes latch boolean as function argument rather than reading it from ros parameter server just like advertiseImage and advertiseCamera.

@k-okada k-okada merged commit b504c59 into jsk-ros-pkg:master Dec 28, 2020
@garaemon garaemon deleted the 2020.12.27-latch-argument branch December 28, 2020 04:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants