Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jsk_data] add wait_timer for timer method #1697

Merged
merged 7 commits into from
Sep 27, 2021

Conversation

shmpwk
Copy link
Contributor

@shmpwk shmpwk commented Aug 20, 2021

As to data_collection_server, wait_service_request for request method was implemented by #1669 .
So I apply it to the other methods such as timer method and all method.

@shmpwk shmpwk changed the title [jsk_data] add wait_service_request for timer and all method [jsk_data] apply wait_service_request for timer and all method Aug 20, 2021
@shmpwk shmpwk changed the title [jsk_data] apply wait_service_request for timer and all method [jsk_data] apply wait_service_request to timer method and all method Aug 20, 2021
@knorth55
Copy link
Member

knorth55 commented Aug 20, 2021

I think waiting for all method is meaningless because all msgs are received and updated in sync_sub_and_save_cb.
but for timer, it might be useful.

@knorth55
Copy link
Member

@shmpwk can you check shmpwk#1 ?

@shmpwk
Copy link
Contributor Author

shmpwk commented Aug 20, 2021

@knorth55 You're right. I just tried it for timer and thought that it can be also applied to all.

@shmpwk
Copy link
Contributor Author

shmpwk commented Aug 20, 2021

Thank you for the revise.
I fix typo on shmpwk#1 by fac3f9c.
I confirm it works with wait_save_request: true or false and wait_timer: true or false.

@knorth55 knorth55 changed the title [jsk_data] apply wait_service_request to timer method and all method [jsk_data] apply wait_service_request to timer method Aug 25, 2021
@knorth55 knorth55 changed the title [jsk_data] apply wait_service_request to timer method [jsk_data] add wait_timer_request for timer method Aug 25, 2021
@knorth55 knorth55 changed the title [jsk_data] add wait_timer_request for timer method [jsk_data] add wait_timer for timer method Aug 25, 2021
@k-okada k-okada merged commit b8ed729 into jsk-ros-pkg:master Sep 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants