New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[jsk_topic_tools/DiagnosticsNodelet] Enable constructor without name argument #1761

Merged

k-okada merged 1 commit into jsk-ros-pkg:master from iory:diagnostics-constructor

Aug 26, 2022

Member

iory commented Aug 25, 2022

What is this?

Related to jsk-ros-pkg/jsk_recognition#2712
The jsk nodes use ConnectionBasedNodelet and DiagnosticsNodelet.

jsk-ros-pkg/jsk_recognition#2712 (comment)
If we want to write the following, we need to create a constructor with no arguments in DiagnosticsNodelet.

#if  defined(JSK_TOPIC_TOOLS_VERSION) and JKS_NODELET_VERSION_MINIMUM(2,2,13))
    #define jsk_topic_tools::NODLET jsk_topic_tools::ConnectionBasedNodelet
#else
    #define jsk_topic_tools::NODLET jsk_topic_tools::DiagnosticNodelet
#endif```


          [jsk_topic_tools/DiagnosticsNodelet] Enable constructor without name …

5293b34

…argument

k-okada merged commit 2a26be4 into jsk-ros-pkg:master

iory deleted the diagnostics-constructor branch

August 26, 2022 02:58

iory mentioned this pull request

[jsk_topic_tools/DiagnosticNodelet] Use node name for diagnostic message #1762

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment