[jsk_topic_tools/DiagnosticNodelet] Use node name for diagnostic message #1762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this?
Related to jsk-ros-pkg/jsk_recognition#2712 and #1761
The DiagnosticNodelet outputs diagnostic messages.
However, the name has been specified by the developer. #1761
This PR allows the user to use connection based nodelets and diagnostics nodelets depending on the version of jsk_topic_tools.
I have also changed the format to make the numbers easier to read.
jsk_recognition package's PR assumes that these changes will be incorporated in the next released version (
2.2.13).