New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ROS-O] do not specify c++ standard #1770
Conversation
it break with current log4cxx which requires c++17. No, going forward it's no option to specify the standard anymore. And it's not necessary either.
the non-hpp headers are deprecated since kinetic
it's deprecated to use global _1 from boost for a while now and the Debian ROS packages do not provide it anymore.
this confused me when I looked through the code.
setup from distutils is deprecated and will be removed eventually.
I added multiple other patches needed to compile on debian testing. |
@v4hn thanks for patches, i have createned new PR #1773 with CI test as well as backward compatibilies. BTW, how did you setup ROS-O build environment, for example are you compile all ros tools from source? or are you using Debian-installed libraries? here is my settings -> |
Great work! |
That being said @jspricke worked on an approach recently to build debs directly from github actions and that might move more and more packages into debian and a custom deb repository in the future. |
@v4hn thanks for explanation and I found that I missed your great talk at ROScon. |
Please open a discussion there, yes. I can ping a few other involved people if there is something concrete to discuss there. |
add test to compile on 22.04, see #1770
it break with current log4cxx which requires c++17. No, going forward it's no option to specify the standard anymore. And it's not necessary either.
@k-okada