add test to compile on 22.04, see #1770 #1773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k-okada
force-pushed
the
ros_o
branch
19 times, most recently
from
9c741c7
to
4e8008c
Compare
it break with current log4cxx which requires c++17. No, going forward it's no option to specify the standard anymore. And it's not necessary either.
the non-hpp headers are deprecated since kinetic
it's deprecated to use global _1 from boost for a while now and the Debian ROS packages do not provide it anymore.
this confused me when I looked through the code.
setup from distutils is deprecated and will be removed eventually.
it break with current log4cxx which requires c++17. No, going forward it's no option to specify the standard anymore. And it's not necessary either. same fix as jsk-ros-pkg@18e200c
it's deprecated to use global _1 from boost for a while now and the Debian ROS packages do not provide it anymore.
k-okada
force-pushed
the
ros_o
branch
2 times, most recently
from
36a8351
to
4dd2c68
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backcompaible version of [ROS-O] do not specify c++ standard (#1770)
Closes #1770