Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Major Release] Remove extract_images_sync that merged in image_view #1633

Merged
merged 1 commit into from Oct 27, 2016
Merged

[Major Release] Remove extract_images_sync that merged in image_view #1633

merged 1 commit into from Oct 27, 2016

Conversation

wkentaro
Copy link
Member

No description provided.

@k-okada
Copy link
Member

k-okada commented May 1, 2016 •
edited

@wkentaro wkentaro force-pushed the remove-extract-images-sync branch 3 times, most recently from c118c89 to d8b200e Compare May 9, 2016 03:53
@wkentaro wkentaro force-pushed the remove-extract-images-sync branch from d8b200e to 8a0e37b Compare May 16, 2016 14:11
@wkentaro
Copy link
Member Author

PLZ merge this.

@wkentaro
Copy link
Member Author

plz merge

@k-okada
Copy link
Member

k-okada commented May 19, 2016

I think we need to wait for #1633 (comment)

@wkentaro
Copy link
Member Author

Ok.

@wkentaro wkentaro changed the title [jsk_perception] Remove extract_images_sync that merged in image_view Remove extract_images_sync that merged in image_view May 28, 2016
@wkentaro wkentaro self-assigned this Jun 1, 2016
@k-okada k-okada mentioned this pull request Aug 1, 2016
Closed
19 tasks
@wkentaro wkentaro changed the title Remove extract_images_sync that merged in image_view [Major Release] Remove extract_images_sync that merged in image_view Sep 17, 2016
@wkentaro wkentaro added this to the 0.4.0 milestone Sep 17, 2016
@k-okada
Copy link
Member

k-okada commented Oct 27, 2016

can we merge even if ros-perception/image_pipeline#164 is not merged yet?

@wkentaro
Copy link
Member Author

Yeah, I think so.
I will revise the current extract_image_sync in image_view to have a feature in image_save_sync.

@k-okada k-okada merged commit 2e4ea0f into jsk-ros-pkg:master Oct 27, 2016
@wkentaro wkentaro deleted the remove-extract-images-sync branch October 27, 2016 12:12
wkentaro referenced this pull request Oct 30, 2016
@k-okada
0.3.27
c2203a3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@wkentaro wkentaro

Labels
enhancement pkg/jsk_perception PR/MergeOK PR/WaitForUpstreamRelease
Projects
None yet
Milestone
0.4.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@wkentaro @k-okada