Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jsk_perception] support sensor_msgs/PanoramaInfo with adding a publisher to DualFisheyeToPanorama node #2579

Merged
merged 10 commits into from Jul 11, 2021

Conversation

sktometometo
Copy link
Contributor

I defined PanoramaInfo message for meta information of panorama images.
The message have fields below.

  • header (std_msgs/Header)
  • projection_model (string)
    • describing the projection model of a panorama image.
    • Currently, only "equirectangular" is used. But use of other projection models is possible. e.g. "mercator"
  • theta_min, theta_max, phi_min, phi_max (float64)

And I added a publisher of PanoramaInfo.msg to DualFisheyeToPanorama for example usage.

@k-okada
Copy link
Member

k-okada commented Mar 12, 2021 via email

@sktometometo
Copy link
Contributor Author

PanoramaInfo.msg is defined in ros/common_msgs#171.

Change panorama info publisher of DualFisheyeToPanorama to use sensor_msgs/Panoramainfo

@sktometometo sktometometo changed the title [jsk_recognition_msgs][jsk_perception] add the PanoramaInfo message and add a publisher to DualFisheyeToPanorama node [jsk_perception] support sensor_msgs/PanoramaInfo with adding a publisher to DualFisheyeToPanorama node Mar 12, 2021
@sktometometo
Copy link
Contributor Author

Example usage of PanoramaInfo will be in #2581

Copy link
Member

@k-okada k-okada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@k-okada
Copy link
Member

k-okada commented Jul 9, 2021

failing with

/workspace/ros/ws_jsk_recognition/src/jsk_recognition/jsk_perception/src/dual_fisheye_to_panorama.cpp:36:
/workspace/ros/ws_jsk_recognition/src/jsk_recognition/jsk_perception/include/jsk_perception/dual_fisheye_to_panorama.h:43:10: fatal error: sensor_msgs/PanoramaInfo.h: No such file or directory
   43 | #include <sensor_msgs/PanoramaInfo.h>
      |          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[2]: *** [CMakeFiles/jsk_perception.dir/build.make:219: CMakeFiles/jsk_perception.dir/src/dual_fisheye_to_panorama.cpp.o] Error 1
make[2]: *** Waiting for unfinished jobs....

add PanoramaInfo on jsk_recognition_msgs until ros/common_msgs#171 merged
@k-okada k-okada merged commit 30f8b7a into jsk-ros-pkg:master Jul 11, 2021
@sktometometo sktometometo deleted the PR/add-panorama-info branch November 24, 2021 03:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants