[audio_to_spectrogram] Enable publishing frequency vs amplitude plot #2654
Conversation
| @@ -35,10 +57,16 @@ def _cb(self, msg): | |||
| self.ax.set_xlim((self.freq.min(), self.freq.max())) | |||
| self.ax.set_ylim((0.0, 20)) | |||
| self.ax.legend(loc='upper right') | |||
| print(self.pub_img.get_num_connections()) | |||
There was a problem hiding this comment.
You may forget to remove this line?
If you need this line, rospy.loginfo or rospy.logdebug seems better.
There was a problem hiding this comment.
Thanks. I forgot to remove the debug print.
Fixed.
| @@ -35,10 +57,16 @@ def _cb(self, msg): | |||
| self.ax.set_xlim((self.freq.min(), self.freq.max())) | |||
| self.ax.set_ylim((0.0, 20)) | |||
| self.ax.legend(loc='upper right') | |||
| print(self.pub_img.get_num_connections()) | |||
| if self.pub_img.get_num_connections() > 0: | |||
There was a problem hiding this comment.
How about using ConnectionBasedTransport?
https://jsk-docs.readthedocs.io/projects/jsk_common/en/latest/jsk_topic_tools/class/python_connection_based_transport.html
There was a problem hiding this comment.
That's good idea, thanks. I modified the code. 2e86235
| self.sub_spectrum = rospy.Subscriber( | ||
| '~spectrum', Spectrum, self._cb, queue_size=1000) | ||
|
|
||
| def unsupported(self): |
There was a problem hiding this comment.
Typo: unsubscribe?
Traceback (most recent call last):
File "/home/leus/ros/melodic/src/jsk-ros-pkg/jsk_recognition/audio_to_spectrogram/scripts/spectrum_plot.py", line 77, in <module>
SpectrumPlot()
File "/home/leus/ros/melodic/src/jsk-ros-pkg/jsk_common/jsk_topic_tools/src/jsk_topic_tools/transport.py", line 26, in __call__
obj = type.__call__(cls, *args, **kwargs)
TypeError: Can't instantiate abstract class SpectrumPlot with abstract methods unsubscribe
There was a problem hiding this comment.
Sorry, I was wrong. Fixed. 4fa0c14
|
I am sorry for the many comments, but the last thing. How about moving these lines to outside of This is because the new |
Don't worry about it. That's a good idea. Modified 6cd009c |
|
Thank you so much! I think this PR is OK to be merged after tests pass. |
|
@iory please add plotted graph image on this comment thread or document |
iory
force-pushed
the
visualize-audio
branch
2 times, most recently
from
1f390c6
to
c57662c
Compare
|
I added the image in the README.md. |
k-okada
force-pushed
the
visualize-audio
branch
from
9ea3974
to
bf7c688
Compare
What is this?
This PR enables publishing frequency vs amplitude plot images in
spectrum_plot.py.