Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create rgb image in depth_image_creator #2102

Merged

Conversation

wkentaro
Copy link
Member

@wkentaro wkentaro commented Jun 2, 2017

Why?

I need to get rgb image seen from different view point for #2104 .

sample_depth_image_creator

cc @YutoUchimi

@wkentaro wkentaro force-pushed the rgb_image_in_depth_image_creator branch from ffcf03a to 0892a4d Compare June 2, 2017 15:13
@k-okada k-okada merged commit 12ac643 into jsk-ros-pkg:master Jun 5, 2017
@wkentaro wkentaro deleted the rgb_image_in_depth_image_creator branch June 5, 2017 05:24
@k-okada
Copy link
Member

k-okada commented Jun 5, 2017

it seems some pixel of created rgb/depth image is black, is it ok? do we loop over image coordinates, not point cloud list?
https://github.com/jsk-ros-pkg/jsk_recognition/pull/2102/files#diff-ace21927127e2a29fdb36ab72b35676cR259

@wkentaro
Copy link
Member Author

wkentaro commented Jun 5, 2017

I think it is ok, the black region has value of nan for depth and 0 for rgb image.
No, we loop over point cloud list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants