Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jsk_pcl_ros: pointcloud_screenpoint: apply lazy nodelet #2268

Closed
wants to merge 4 commits into from

Conversation

furushchev
Copy link
Member

@furushchev furushchev commented Apr 16, 2018

Rewrite version of pointcloud_screenpoint using connection_based_nodelet.
This PR includes:

  • Applied connection_based_nodelet that replaces the existing nodelet which always subscribe pointcloud that makes serious overhead
  • Support dynamic reconfigure for changing parameters dynamically

@k-okada
Copy link
Member

k-okada commented Apr 17, 2018

+ rosdep install -q -y --rosdistro indigo -n -q -r --ignore-src --from-paths /opt/ros/indigo/share .
executing command [pip install -U -q chainercv]
launchpadlib 1.10.2 requires testresources, which is not installed.
Cannot uninstall 'six'. It is a distutils installed project and thus we cannot accurately determine which files belong to it which would lead to only a partial uninstall.
executing command [pip install -U -q fcn]
launchpadlib 1.10.2 requires testresources, which is not installed.
chainer 3.5.0 has requirement numpy>=1.9.0, but you'll have numpy 1.8.2 which is incompatible.
pandas 0.22.0 has requirement numpy>=1.9.0, but you'll have numpy 1.8.2 which is incompatible.
Cannot uninstall 'six'. It is a distutils installed project and thus we cannot accurately determine which files belong to it which would lead to only a partial uninstall.
executing command [pip install -U -q percol]
launchpadlib 1.10.2 requires testresources, which is not installed.
Cannot uninstall 'six'. It is a distutils installed project and thus we cannot accurately determine which files belong to it which would lead to only a partial uninstall.
executing command [pip install -U -q chainer]
launchpadlib 1.10.2 requires testresources, which is not installed.
Cannot uninstall 'six'. It is a distutils installed project and thus we cannot accurately determine which files belong to it which would lead to only a partial uninstall.
ERROR: the following rosdeps failed to install
  pip: command [pip install -U -q chainercv] failed
  pip: command [pip install -U -q fcn] failed
  pip: command [pip install -U -q percol] failed
  pip: command [pip install -U -q chainer] failed
  pip: Failed to detect successful installation of [chainercv]
  pip: Failed to detect successful installation of [fcn]
  pip: Failed to detect successful installation of [percol]
  pip: Failed to detect successful installation of [chainer]
+ EXIT_STATUS=1

@furushchev
Copy link
Member Author

need to wait for #2260 ?

@wkentaro
Copy link
Member

I'm not sure. I have no idea how to make the test pass on Kinetic, currently. :(

@furushchev
Copy link
Member Author

Maybe also need to be considered on #2260, Now it seems chainer does not work on the old numpy installed by apt-get install python-numpy.
We may need to consider about workaround.

  1. Install the latest numpy from pip before apt-get install python-numpy
  2. Install the latest numpy in overlayed user space?
  3. Install old chainer, chainercv between rosdep install and catkin build
  4. Any other idea?

@wkentaro Which do you think is better?
CC: @k-okada

@k-okada
Copy link
Member

k-okada commented Apr 24, 2018

  1. how did you find numpy/chainer problem
00:14:58.521 + rosdep install -q -y --rosdistro indigo -n -q -r --ignore-src --from-paths /opt/ros/indigo/share .
00:15:33.164 matplotlib 1.3.1 requires tornado, which is not installed.
00:15:33.321 Cannot uninstall 'six'. It is a distutils installed project and thus we cannot accurately determine which files belong to it which would lead to only a partial uninstall.
00:15:41.060 Command "python setup.py egg_info" failed with error code 1 in /tmp/pip-install-uISNiM/tornado/
00:15:43.069 matplotlib 1.3.1 requires tornado, which is not installed.
00:15:43.078 Cannot uninstall 'six'. It is a distutils installed project and thus we cannot accurately determine which files belong to it which would lead to only a partial uninstall.
00:15:47.718 matplotlib 1.3.1 requires tornado, which is not installed.
00:15:47.859 Cannot uninstall 'six'. It is a distutils installed project and thus we cannot accurately determine which files belong to it which would lead to only a partial uninstall.
00:15:58.471 ERROR: the following rosdeps failed to install
00:15:58.471   pip: command [pip install -U -q chainercv] failed
00:15:58.471   pip: command [pip install -U -q fcn] failed
00:15:58.471   pip: command [pip install -U -q percol] failed
00:15:58.471   pip: command [pip install -U -q chainer] failed
00:15:58.472   pip: Failed to detect successful installation of [chainercv]
00:15:58.472   pip: Failed to detect successful installation of [fcn]
00:15:58.472   pip: Failed to detect successful installation of [percol]
00:15:58.472   pip: Failed to detect successful installation of [chainer]
  1. what is working version of chainer/chainercv

  2. please COMPLAIN to chainer developers.

@k-okada
Copy link
Member

k-okada commented Apr 24, 2018

root@667f0938c31d:~/jsk_recognition/jsk_perception# python -c 'import chainer'
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/usr/local/lib/python2.7/dist-packages/chainer/__init__.py", line 28, in <module>
    from chainer import training  # NOQA
  File "/usr/local/lib/python2.7/dist-packages/chainer/training/__init__.py", line 2, in <module>
    from chainer.training import extensions  # NOQA
  File "/usr/local/lib/python2.7/dist-packages/chainer/training/extensions/__init__.py", line 30, in <module>
    from chainer.training.extensions.variable_statistics_plot import VariableStatisticsPlot  # NOQA
  File "/usr/local/lib/python2.7/dist-packages/chainer/training/extensions/variable_statistics_plot.py", line 16, in <module>
    _plot_color = matplotlib.colors.to_rgba('#1f77b4')  # C0 color
AttributeError: 'module' object has no attribute 'to_rgba'

are you sure about numpy?????

@furushchev
Copy link
Member Author

I found it:

+ rosdep install -q -y --rosdistro indigo -n -q -r --ignore-src --from-paths /opt/ros/indigo/share .
launchpadlib 1.10.2 requires testresources, which is not installed.
Cannot uninstall 'six'. It is a distutils installed project and thus we cannot accurately determine which files belong to it which would lead to only a partial uninstall.
launchpadlib 1.10.2 requires testresources, which is not installed.
chainer 4.0.0 has requirement numpy>=1.9.0, but you'll have numpy 1.8.2 which is incompatible.
pandas 0.22.0 has requirement numpy>=1.9.0, but you'll have numpy 1.8.2 which is incompatible.
Cannot uninstall 'six'. It is a distutils installed project and thus we cannot accurately determine which files belong to it which would lead to only a partial uninstall.
launchpadlib 1.10.2 requires testresources, which is not installed.
Cannot uninstall 'six'. It is a distutils installed project and thus we cannot accurately determine which files belong to it which would lead to only a partial uninstall.
launchpadlib 1.10.2 requires testresources, which is not installed.
Cannot uninstall 'six'. It is a distutils installed project and thus we cannot accurately determine which files belong to it which would lead to only a partial uninstall.
ERROR: the following rosdeps failed to install
  pip: command [pip install -U -q chainercv] failed
  pip: command [pip install -U -q fcn] failed
  pip: command [pip install -U -q percol] failed
  pip: command [pip install -U -q chainer] failed
  pip: Failed to detect successful installation of [chainercv]
  pip: Failed to detect successful installation of [fcn]
  pip: Failed to detect successful installation of [percol]
  pip: Failed to detect successful installation of [chainer]
executing command [pip install -U -q chainercv]
executing command [pip install -U -q fcn]
executing command [pip install -U -q percol]
executing command [pip install -U -q chainer]
+ EXIT_STATUS=1

from http://jenkins.jsk.imi.i.u-tokyo.ac.jp:8080/job/trusty-travis-jsk-ros-pkg-jsk-recognition-indigo-deb-true-true/1453/

@k-okada
Copy link
Member

k-okada commented Apr 24, 2018 via email

@furushchev
Copy link
Member Author

How about the line?:
chainer 4.0.0 has requirement numpy>=1.9.0, but you'll have numpy 1.8.2 which is incompatible.

@k-okada
Copy link
Member

k-okada commented Apr 25, 2018

move to #2277

@k-okada k-okada closed this Apr 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants