[jsk_pcl_ros] Delete subclass's updateDiagnostic method #2323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
furushchev
requested changes
Aug 24, 2018
|
Thank you for your review! |
|
@iory Could you also rebase commits and update the title of this PR? |
iory
changed the title
iory
changed the title
|
OK. I rebased and modified title. |
furushchev
approved these changes
Aug 24, 2018
|
@iory Thanks for iterating. Now LGTM! |
|
I think this change assumes some recent version of upstream package. If so, can you add that information to build/run depend of package.xml? |
|
This change assumes jsk_topic_tools 2.2.7, and it is already added in package.xml. |
|
@k-okada |
|
please fix for travis
--
◉ Kei Okada
2018年8月28日(火) 11:19 iory <notifications@github.com>:
… @k-okada <https://github.com/k-okada>
Please check this PR
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2323 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAeG3H002uqCgfKI3yqEf7wGix7z7xdKks5uVKiSgaJpZM4WKwEX>
.
|
|
@k-okada |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In jsk_pcl_ros, depth_calibration_nodelet, line_segment_detector_nodelet and line_segment_collector_nodelet are not updating diagnostics.
Before this PR, they output error of diagnostics with "No message was set" message and
we can not change the error level.
Like this
After this PR, we can change the error level.