[doc] [jsk_pcl_ros_utils] [jsk_pcl_ros] Add documentation #2393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YutoUchimi
force-pushed
the
jsk_pcl_doc
branch
from
bb38cae
to
04694f1
Compare
YutoUchimi
force-pushed
the
jsk_pcl_doc
branch
from
104b1fe
to
5f9baf9
Compare
|
Done. BTW, I think we have to re-enable build trigger for jsk_docs in Read the Docs (jsk-ros-pkg/jsk_docs#25) before or after this PR is merged. |
YutoUchimi
changed the title
knorth55
reviewed
Feb 27, 2019
|
I ran all tests and they passed in my environment |
|
I confirmed that all tests are enabled in CMakelists.txt |
knorth55
approved these changes
Mar 19, 2019
|
Great work!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1631
This PR fixes code minimally and adds sample, test and documentation for below nodes.
jsk_pcl_ros
jsk_pcl/PointCloudMoveitFilter(This is not a node but a MoveIt plugin.)jsk_pcl_ros_utils