Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jsk_pcl_ros/pointcloud_moveit_filter] build support moveit > 1.0.0 #2443

Merged
merged 2 commits into from
Jul 10, 2019

Conversation

knorth55
Copy link
Member

@knorth55 knorth55 commented Jul 9, 2019

current implementation cause build failure with moveit 1.0.0.
I change to be build with moveit 1.0.0.
I build Kinetic with moveit 1.0.2.

@knorth55 knorth55 requested a review from YutoUchimi July 9, 2019 10:31
@knorth55 knorth55 added the bug label Jul 9, 2019
@k-okada
Copy link
Member

k-okada commented Jul 9, 2019

@knorth55
Copy link
Member Author

knorth55 commented Jul 9, 2019 via email

@k-okada
Copy link
Member

k-okada commented Jul 9, 2019 via email

@knorth55
Copy link
Member Author

knorth55 commented Jul 10, 2019

current master checks if it is melodic or not #if ROS_VERSION_MINIMUM(1,14,0) // melodic.
I change it to check (melodic or MoveIt1.0) or not.

@k-okada k-okada merged commit bbe1bcf into jsk-ros-pkg:master Jul 10, 2019
@k-okada
Copy link
Member

k-okada commented Jul 10, 2019

I see,thanks.

@knorth55 knorth55 deleted the support-moveit-1 branch July 10, 2019 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants