-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[baxtereus] add :angle-vector-sequence for moveit #728
Conversation
@@ -249,15 +249,17 @@ | |||
(when (send self :simulation-modep) | |||
(return-from :angle-vector (send* self :angle-vector-raw av tm args))) | |||
(when (not (numberp tm)) | |||
(ros::warn ":angle-vector tm is not a number, use :angle-vector av tm args")) | |||
(ros::warn ":angle-vector tm is not a number, use :angle-vector av tm args~%")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
better to use
(warning-message 3 "hoge")
??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you
(return-from :angle-vector (send* self :angle-vector-raw av tm args))))) | ||
(:angle-vector-sequence (avs &rest args) | ||
(send* self :angle-vector-sequence-raw avs args)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can set multiple waypoint in planning. how about add multiple jointconstraint at https://github.com/jsk-ros-pkg/jsk_pr2eus/blob/master/pr2eus_moveit/euslisp/robot-moveit.l#L224 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@k-okada i tried to make :angle-vector-sequence-motion-plan
method in jsk-ros-pkg/jsk_pr2eus#259, but i got error
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
error fixed
3176fba
to
d183604
Compare
d183604
to
895ac04
Compare
895ac04
to
4f3c712
Compare
with this code, non-move-arm (i.e. :rarm if move-arm is :larm) moves and follow normal angle-vector (without moveit) even if move-arm is set. detail information: see jsk-ros-pkg/jsk_robot#728
3f38ec6
to
f49d8c9
Compare
edfb2a3
to
1118887
Compare
:angle-vector-sequence -> :angle-vector-sequence-motion-plan
1118887
to
075386d
Compare
please merge this |
Requires jsk-ros-pkg/jsk_pr2eus#259
Main Change
:angle-vector-sequence
for moveit:angle-vector-sequence
->:angle-vector-sequence-motion-plan
Minor Change
baxter-util.l