Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visualization of NBA points per game vs. salary #1

Closed
7 of 8 tasks
jsoma opened this issue Jul 13, 2017 · 5 comments
Closed
7 of 8 tasks

Visualization of NBA points per game vs. salary #1

jsoma opened this issue Jul 13, 2017 · 5 comments

Comments

@jsoma
Copy link
Owner

jsoma commented Jul 13, 2017

Pitch

Summary

I found NBA player salaries on ESPN's site, and I'd like to link it with some performance data. I'm certain Stephen Curry is underpaid for how many points he scores per game.

It would be like this chart but with salary on the y-axis and points on the x-axis

image

Details

Possible headline(s): The NBA's Most Underpaid Players

Data set(s): NBA salary data and NBA performance data

Code repository: https://github.com/jsoma/sample-pages/tree/master/code/a-very-cool-project

Possible problems/fears/questions: I don't actually know anything about basketball so this is going to be difficult

Work so far

Tip: To upload an image, just drag it onto the text area.

I've opened the data, cleaned it, done a little plotting, and come up with this ugly graph:

image

Checklist

This checklist must be completed before you submit your draft.

  • I have already spent time with my data set, opening it, exploring it, etc
  • I have created a "DIARY.md" file to save links and list all of the terrible, no good problems I come across
  • My issue issue has [Project] in the title
  • My issue links to my data set(s)
  • My issue links to my code repository
  • My issue explains what I'd like to explore in the data set
  • My issue includes images - either inspiration or what I've done so far
  • I have received two comments of peer feedback on my pitch issue
@jsoma jsoma changed the title Visualization of NBA points per game vs. salary [Project] Visualization of NBA points per game vs. salary Jul 13, 2017
@jsoma
Copy link
Owner Author

jsoma commented Jul 14, 2017

I love the idea, and I think it's going to get people really excited. Are you going to use the same colors as the chart you linked, or pick something on your own?

Points-per-game isn't the best or only metric to judge someone, though, maybe you could provide a few different scatterplots and compare them?

Fivethirtyeight has done a lot of talking about Steph Curry, maybe you can get some ideas by looking at this piece: http://fivethirtyeight.com/features/stephen-curry-is-the-revolution/

Tips about how to provide feedback:

  • Stay positive: people are putting themselves out there by pitching! Even if you think it's terrible and boring, it was still interesting enough to them to pitch it.
  • Provide helpful feedback and ideas: for every idea there's something that could be made better about it, even if it's wonderful. Sometimes it's taking something out of the project, and sometimes it's adding something in.
  • The best feedback is "something that you like, and something that could be improved." And don't worry if your feedback isn't any good, I give useless feedback all of the time.

@jsoma
Copy link
Owner Author

jsoma commented Jul 14, 2017

A few different charts is a really good idea. Maybe I'll add a few more in like blocks and fouls, "See who's is getting paid the most to foul other members of the NBA?" could be a good headline.

I'll go interview some basketball fanatics to get their points of view, too, since basketball isn't really my strong suit.

Tips about responding to feedback:

  • Appreciate it! Even if you disagree with their thoughts, maybe everyone on the planet agrees with whatever nonsense that person said. Peer review won't get your pitch approved or denied, but it can help you
  • Beyond just thanking, talk about what you're going to do and the thoughts you're having - kind of like "thinking out loud." It will help the editorial folks understand how you're approaching the project.

@jsoma
Copy link
Owner Author

jsoma commented Jul 14, 2017

Update

Content

447e7346-4f65-11e6-8657-eaaca1a6b939-1

Pretend I wrote some words here.

Any changes in direction or topic?

I was going to make multiple graphics, but this one really was the one that jumped out. The data was pretty easy to work with, though, so I have time to make a lot more if you think I should.

Problems/Questions

I'm curious to see about what people think about the font choice and colors. Does it get the story across?

I also don't know how to change the numbers on the axes in matplotlib

Checklist

  • I have included my visuals
  • I have added writing about my topic
  • I have been updating my DIARY.md with details about my process
  • I have uploaded/updated any Jupyter Notebooks or other datasets into my code repository
  • I have received two comments of peer feedback on my project update

@jsoma
Copy link
Owner Author

jsoma commented Jul 14, 2017

Pretend I gave some really useful feedback here

@jsoma
Copy link
Owner Author

jsoma commented Jul 14, 2017

Final

Project visuals/text

bb80982a-4f65-11e6-8b5b-08b5ffd01f8d

Pretend, again, that I wrote some great text here.

Details

Headline: This ain't fair! Underpaid basketball players

Published website version: https://jsoma.github.io/sample-pages/a-very-cool-project/

Code repository: https://github.com/jsoma/sample-pages/tree/master/code/a-very-cool-project

Final data set(s): NBA salary data and NBA performance data

What did you find to be the most difficult part of this project?

I don't know anything about basketball, so I had to talk to a lot of people to find out what everyone would be interested in, and whether my graphic would make sense!

Are you satisfied with what you produced? Is there anything you would like to change or improve?

I would like to make an interactive version where when I mouse over one of the dots it turns into a head and starts playing that basketball player's favorite song.

Checklist

  • I have included my visuals
  • I have posted my project to my project website
  • I have been updating my DIARY.md with details about my process
  • I have uploaded/updated any Jupyter Notebooks or other datasets into my code repository

@Dgorgs Dgorgs mentioned this issue Jul 17, 2017
8 tasks
@Dgorgs Dgorgs mentioned this issue Jul 24, 2017
8 tasks
@julialedur julialedur mentioned this issue Jul 18, 2018
6 tasks
@benbitoun benbitoun mentioned this issue Jul 24, 2018
1 task
@benbitoun benbitoun mentioned this issue Jul 31, 2018
3 tasks
@adrianblanco adrianblanco mentioned this issue Jul 31, 2018
6 tasks
@vpenney vpenney mentioned this issue Aug 15, 2018
6 tasks
@Win-spider Win-spider mentioned this issue Mar 25, 2020
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant