pickler: create copies of seen objects #338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 14, 2021
Previously the make_refs=False / unpicklable=False code path would avoid emitting data for objects it had already seen. It mostly did this to avoid cycles, as its reference system is disabled in these modes. The end result was that null was emitted for any objects that appear more than once in the object graph. Improve the behavior by keeping track of objects that we have already flattened and return the pre-flattened representation when we re-encounter the same object. This is a simple solution that fixes encoding of datetime objects with UTC tzinfo in these scenarios. It also improves encoding of objects with multiple references to the same object as the object will now be properly encoded each time it is encountered in the object graph. Resolves jsonpickle#333 jsonpickle#334 jsonpickle#337 Signed-off-by: David Aguilar <davvid@gmail.com>
This was referenced Jan 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the make_refs=False / unpicklable=False code path
would avoid emitting data for objects it had already seen.
It mostly did this to avoid cycles, as its reference
system is disabled in these modes, and thus the result
was that null was emitted for any objects that appear
more than once in the object graph.
Improve the behavior by keeping track of objects that we
have already flattened and simply return the pre-flattened
representation when we re-encounter the same object.
This is a simple solution that fixes encoding of datetime
objects with UTC tzinfo in these scenarios.
Resolves #333 #334 #337
Signed-off-by: David Aguilar davvid@gmail.com