Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading the test suite to Postgis 3.1 #52

Closed
Nek- opened this issue Jun 9, 2021 · 1 comment
Closed

Upgrading the test suite to Postgis 3.1 #52

Nek- opened this issue Jun 9, 2021 · 1 comment

Comments

@Nek-
Copy link
Contributor

Nek- commented Jun 9, 2021

Hello. I worked on making the testsuite work for PHP 8.0 and I was testing stuff with postgis 3.1.

There's a lot of work to test postgis 1.5, 2.0, 2.1, and 2.2. But it's even harder now because many many many outputs from postgis have changed. Especially precision in calculations (leading to barely all numbers wrong in expected results).

To support PHP 7.1 as well as 8.0 in the test suite, I currently have no other solution than using the PHPUnit Bridge of Symfony, but it seems working nicely.

I post this because I can push my code as a PR but I want to know if you're ok to drop testsuite for old versions of postgis. If so, I'll send a pull request. (the work I did so far is already huge, so I'm not going to make old versions of postgis work with it)

@jsor
Copy link
Owner

jsor commented Oct 7, 2021

Fixed and released in v2.0.0.

@jsor jsor closed this as completed Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants