Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vimeo videos won't fullscreen on Firefox #234

Closed
Julix91 opened this issue Jan 24, 2020 · 1 comment
Closed

Vimeo videos won't fullscreen on Firefox #234

Julix91 opened this issue Jan 24, 2020 · 1 comment

Comments

@Julix91
Copy link

Julix91 commented Jan 24, 2020

Similar to #163

https://vimeo.zendesk.com/hc/en-us/articles/115015759768-Fullscreen-button-missing-from-the-player

When Vimeo is loaded in an iframe that doesn't have fullscreen permissions then it doesn't show the fullscreen button (on Mozilla Firefox).

Couldn't lity just add the mozallowfullscreen webkitallowfullscreen allowfullscreen props to the iframe it creates? Is that an option somewhere?

@Julix91
Copy link
Author

Julix91 commented Jan 24, 2020

Nevermind, lity already adds allowfullscreen and it was a problem with some custom code that was adding allow="autoplay; fullscreen" but not allowfullscreen and it seems that the other versions haven't been needed in a long while. My bad! :)

@Julix91 Julix91 closed this as completed Jan 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant