Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Meta-issue: What hacks could we remove from our checker if we made additional changes upstream? #6

Open
cpovirk opened this issue Oct 27, 2020 · 0 comments

Comments

@cpovirk
Copy link
Collaborator

cpovirk commented Oct 27, 2020

So far, I've opened issues only for changes that I've suspected we absolutely need to make to CF in order to make our checker work.

But there are plenty of places in which our checker could be cleaner (read: less hacky) if we made additional changes to CF. Just to pick the most recent example, I can't imagine that anyone would feel great about how I default type-variable usages only conditionally. Perhaps CF could have native support for this. [update: I backed out my hack because it was -- who could have guessed? :) -- buggy. And I have replaced it with another upstreaming proposal, #7. But the general point stands. To offer a new example, I present another fragile-looking hack.]

But some of our needs make little sense to 99% of CF checkers. So, as with many of the changes we've already made in this CF fork, we may find it hard to argue for supporting them upstream. Still, it would be nice to eventually look into the possibility of replacing hacks with CF changes: Hacks often break somewhere down the line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant