-
-
Notifications
You must be signed in to change notification settings - Fork 274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow version tags in aliases #2480
Allow version tags in aliases #2480
Conversation
Here are my TS fixes: https://github.com/Hypercubed/jspm-cli/tree/fix/ts-issues Not sure if you need these. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing! Please add yourself to CONTRIBUTORS if not already - https://github.com/jspm/jspm-cli/blob/master/CONTRIBUTORS.
Also the TypeScript fixes would be great to include either in this PR or another. I usually run the build with vscode so that's why that folder is checked in.
src/install/index.ts
Outdated
install.name = install.target.name.substr(install.target.name.lastIndexOf(':') + 1); | ||
const idx = install.target.name.lastIndexOf(':') + 1; | ||
const substr = install.target.name.substr(idx); | ||
if (substr.match(validAlaisRegEx)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure I follow this part since install.target
is supposed to be the registry:name@version
thing right? So in jspm install @x=x
, the install.target
should be the npm:x
part right? Not the @x
part? It's been a while since I've looked at this code, so maybe you can clarify this for me?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was not really necessary for this PR. This was a refactor to reduce some redundant code while I was debugging.
@guybedford Did you see the changes here: https://github.com/Hypercubed/jspm-cli/tree/fix/ts-issues? Not sure if or how this was working previously.... but I need that to run the tests. |
I updated this PR including the changes I need to get TS to run. |
Published in 2.0.0-beta.5. Thanks so much for the ts build fixes too. Usually we don't commit the build changes, and only do that for release, but it was fine here. |
Hi, Command : Error raised :
|
Released in 2.0.0-beta.6. |
Oof... that was a half completed change. Thanks! |
Here is PR for allowing version tags in aliases for your review.
Note: I had a hard time compiling this for testing. I was seeing many TS errors that I needed to hack around. What is your build process? Can we add that to the package scripts?