dot-prop 4.0.0 is written in ES2015 #985

oligot · 2016-10-11T09:15:35Z

Starting with version 4.0.0, the library dot-prop is now written in ES2015,
which means it doesn't work in IE anymore or when minifying the
code with uglifyjs as the code isn't transpiled.
This commit set es6 as format so that the code is transpiled and
works in IE and when minifying with uglifyjs

Starting with version 4.0.0, the library [dot-prop](https://github.com/sindresorhus/dot-prop) is now [written in ES2015](sindresorhus/dot-prop@88b6eb6), which means it doesn't work in IE anymore or when minifying the code with uglifyjs as the code isn't transpiled. This commit set es6 as format so that the code is transpiled and works in IE and when minifying with uglifyjs

guybedford · 2016-10-11T10:45:42Z

package-overrides/npm/dot-prop@4.0.0.json

@@ -0,0 +1,3 @@
+{
+  "format": "es6"


"format": "esm" is preferred here. Also note to add jspmNodeConversion: false as well if that is intended.

Ah I see it isn't using modules, just ES features, so just the change to format: 'esm' should be fine here.

Done.
Out out curiosity, what is the difference between "format": "esm" and "format": "es6" ?
I always use the latter: should I always use the former instead ?

guybedford · 2016-10-11T11:14:44Z

Sorry just looking at this again since it is CommonJS, how is this even working with this override? Are you sure you have tested this properly?

oligot · 2016-10-11T11:34:34Z

Yes, I've tested it.
Here is a small project with the override in the package.json file: https://github.com/oligot/jspm-override-dot-prop.
If you remove the override in the package.json file, reinstall the dependencies (rm -rf jspm_packages && jspm install) and try to build with npm run build, there is an error in uglifyjs (probably due to the fact that uglifyjs doesn't understand ES2015 yet)

Error: SyntaxError: Unexpected token name «i», expected punc «;» (line: 38, col: 11, pos: 5174)

     Error
         at new JS_Parse_Error (eval at <anonymous> (/home/oli/src/jspm-override-dot-prop/node_modules/jspm/node_modules/uglify-js/tools/node.js:28:1), <anonymous>:1545:18)
         at js_error (eval at <anonymous> (/home/oli/src/jspm-override-dot-prop/node_modules/jspm/node_modules/uglify-js/tools/node.js:28:1), <anonymous>:1553:11)
         at croak (eval at <anonymous> (/home/oli/src/jspm-override-dot-prop/node_modules/jspm/node_modules/uglify-js/tools/node.js:28:1), <anonymous>:2092:9)
         at token_error (eval at <anonymous> (/home/oli/src/jspm-override-dot-prop/node_modules/jspm/node_modules/uglify-js/tools/node.js:28:1), <anonymous>:2100:9)
         at expect_token (eval at <anonymous> (/home/oli/src/jspm-override-dot-prop/node_modules/jspm/node_modules/uglify-js/tools/node.js:28:1), <anonymous>:2113:9)
         at expect (eval at <anonymous> (/home/oli/src/jspm-override-dot-prop/node_modules/jspm/node_modules/uglify-js/tools/node.js:28:1), <anonymous>:2116:36)
         at regular_for (eval at <anonymous> (/home/oli/src/jspm-override-dot-prop/node_modules/jspm/node_modules/uglify-js/tools/node.js:28:1), <anonymous>:2357:9)
         at for_ (eval at <anonymous> (/home/oli/src/jspm-override-dot-prop/node_modules/jspm/node_modules/uglify-js/tools/node.js:28:1), <anonymous>:2353:16)
         at eval (eval at <anonymous> (/home/oli/src/jspm-override-dot-prop/node_modules/jspm/node_modules/uglify-js/tools/node.js:28:1), <anonymous>:2232:24)
         at eval (eval at <anonymous> (/home/oli/src/jspm-override-dot-prop/node_modules/jspm/node_modules/uglify-js/tools/node.js:28:1), <anonymous>:2139:24)
         at block_ (eval at <anonymous> (/home/oli/src/jspm-override-dot-prop/node_modules/jspm/node_modules/uglify-js/tools/node.js:28:1), <anonymous>:2432:20)
         at eval (eval at <anonymous> (/home/oli/src/jspm-override-dot-prop/node_modules/jspm/node_modules/uglify-js/tools/node.js:28:1), <anonymous>:2404:25)
         at function_ (eval at <anonymous> (/home/oli/src/jspm-override-dot-prop/node_modules/jspm/node_modules/uglify-js/tools/node.js:28:1), <anonymous>:2410:15)
         at eval (eval at <anonymous> (/home/oli/src/jspm-override-dot-prop/node_modules/jspm/node_modules/uglify-js/tools/node.js:28:1), <anonymous>:2235:24)
         at eval (eval at <anonymous> (/home/oli/src/jspm-override-dot-prop/node_modules/jspm/node_modules/uglify-js/tools/node.js:28:1), <anonymous>:2139:24)
         at block_ (eval at <anonymous> (/home/oli/src/jspm-override-dot-prop/node_modules/jspm/node_modules/uglify-js/tools/node.js:28:1), <anonymous>:2432:20)
         at minify (/home/oli/src/jspm-override-dot-prop/node_modules/jspm/node_modules/systemjs-builder/lib/output.js:79:11)
         at exports.writeOutputs (/home/oli/src/jspm-override-dot-prop/node_modules/jspm/node_modules/systemjs-builder/lib/output.js:153:14)
         at /home/oli/src/jspm-override-dot-prop/node_modules/jspm/node_modules/systemjs-builder/lib/builder.js:805:14
         at tryCatcher (/home/oli/src/jspm-override-dot-prop/node_modules/jspm/node_modules/systemjs-builder/node_modules/bluebird/js/release/util.js:16:23)
         at Promise._settlePromiseFromHandler (/home/oli/src/jspm-override-dot-prop/node_modules/jspm/node_modules/systemjs-builder/node_modules/bluebird/js/release/promise.js:510:31)
         at Promise._settlePromise (/home/oli/src/jspm-override-dot-prop/node_modules/jspm/node_modules/systemjs-builder/node_modules/bluebird/js/release/promise.js:567:18)
         at Promise._settlePromise0 (/home/oli/src/jspm-override-dot-prop/node_modules/jspm/node_modules/systemjs-builder/node_modules/bluebird/js/release/promise.js:612:10)
         at Promise._settlePromises (/home/oli/src/jspm-override-dot-prop/node_modules/jspm/node_modules/systemjs-builder/node_modules/bluebird/js/release/promise.js:691:18)
         at Promise._fulfill (/home/oli/src/jspm-override-dot-prop/node_modules/jspm/node_modules/systemjs-builder/node_modules/bluebird/js/release/promise.js:636:18)
         at Promise._resolveCallback (/home/oli/src/jspm-override-dot-prop/node_modules/jspm/node_modules/systemjs-builder/node_modules/bluebird/js/release/promise.js:431:57)
         at Promise._settlePromiseFromHandler (/home/oli/src/jspm-override-dot-prop/node_modules/jspm/node_modules/systemjs-builder/node_modules/bluebird/js/release/promise.js:522:17)
         at Promise._settlePromise (/home/oli/src/jspm-override-dot-prop/node_modules/jspm/node_modules/systemjs-builder/node_modules/bluebird/js/release/promise.js:567:18)
         at Promise._settlePromise0 (/home/oli/src/jspm-override-dot-prop/node_modules/jspm/node_modules/systemjs-builder/node_modules/bluebird/js/release/promise.js:612:10)
         at Promise._settlePromises (/home/oli/src/jspm-override-dot-prop/node_modules/jspm/node_modules/systemjs-builder/node_modules/bluebird/js/release/promise.js:691:18)
         at Promise._fulfill (/home/oli/src/jspm-override-dot-prop/node_modules/jspm/node_modules/systemjs-builder/node_modules/bluebird/js/release/promise.js:636:18)
         at Promise._resolveCallback (/home/oli/src/jspm-override-dot-prop/node_modules/jspm/node_modules/systemjs-builder/node_modules/bluebird/js/release/promise.js:431:57)

guybedford · 2016-10-19T14:29:04Z

I get if it builds, but I mean does the code run? If you disable uglify does it work correctly?

oligot · 2016-10-20T07:54:41Z

Indeed, it doesn't work.
Here is the error I get in the console

Uncaught (in promise) Error: (SystemJS) require is not defined
    ReferenceError: require is not defined

So, it seems like with "format": "esm", we can only use ES6 module syntax (import/export).
Is there a way to configure a package so that it is recognized as an ES6 package (meaning, it will be transpiled with Babel) BUT is uses Node.js require instead of import to load dependencies ?

guybedford · 2016-10-20T10:15:20Z

Exactly. This use case can be described by setting format: 'cjs' but then still configuring the Babel loader. But this would basically mean:

{
  "format": "cjs",
  "meta": {
    "*.js": {
      "loader": "babel"
    }
  }
}

The only problem with the above is it then makes the Babel loader a dependency of the project - there is no way in jspm currently to describe that the code uses the latest ES features without tying it to a transpiler instance. I think the edge cases of transpilation are still a little bit too inconsistent for that sort of conceptual model unfortunately.

oligot · 2016-10-21T07:12:36Z

I just tried it but it doesn't work (I'm still having this error when building): oligot/jspm-override-dot-prop@173dcd9.
Do you have an idea why it doesn't work ?

guybedford · 2016-10-21T10:07:28Z

The above configuration is in jspm 0.17 only.

oligot · 2016-10-21T11:54:41Z

I've updated the project to jspm 0.17 but it still does not work.

system.src.js:122 Uncaught (in promise) Error: (SystemJS) require is not a function
    TypeError: require is not a function
        at execute (http://localhost:2000/jspm_packages/npm/dot-prop@4.0.0/index.js!transpiled:30:12)
    Error loading http://localhost:2000/app.js
        at execute (http://localhost:2000/jspm_packages/npm/dot-prop@4.0.0/index.js!transpiled:30:12)
    Error loading http://localhost:2000/app.js

guybedford · 2016-10-21T12:02:33Z

Perhaps try setting format: 'cjs' as well explicitly in the override.

oligot · 2016-10-21T13:05:49Z

It's already set

guybedford · 2016-10-25T12:29:36Z

@oligot it seems this is a bug. Try instead:

{
  "meta": {
    "*.js": {
      "loader": "plugin-babel",
      "format": "cjs"
    }
  }
}

oligot · 2016-10-27T07:51:47Z

It works now, thanks !
Note that I also had to put "modularRuntime": false in jspm.config.js

I'll update the PR accordingly.

oligot · 2016-10-27T07:56:27Z

Done

guybedford · 2016-10-27T10:14:14Z

Glad to hear it is working. As mentioned previously though this isn't suitable for an override because it carries too many assumptions to provide to everyone. I would suggest keeping this as a local override in your project rather.

oligot · 2016-10-27T10:26:37Z

Ok, let's close the PR then.

guybedford reviewed Oct 11, 2016

View reviewed changes

review: use format esm instead of es6

271b467

guybedford mentioned this pull request Oct 25, 2016

Package format not available in metadata at translate time systemjs/systemjs#1472

Closed

Olivier Ligot added 2 commits October 27, 2016 09:52

Remove vim swp file

11ac37b

Set loader as plugin-babel and format as cjs

8a514bb

oligot closed this Oct 27, 2016

oligot mentioned this pull request Feb 6, 2017

Why don't you add ES5 transpiled code to your modules for browsers? sindresorhus/ama#446

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

dot-prop 4.0.0 is written in ES2015 #985

dot-prop 4.0.0 is written in ES2015 #985

oligot commented Oct 11, 2016

guybedford Oct 11, 2016

guybedford Oct 11, 2016

oligot Oct 11, 2016

guybedford commented Oct 11, 2016

oligot commented Oct 11, 2016

guybedford commented Oct 19, 2016

oligot commented Oct 20, 2016

guybedford commented Oct 20, 2016

oligot commented Oct 21, 2016

guybedford commented Oct 21, 2016

oligot commented Oct 21, 2016

guybedford commented Oct 21, 2016

oligot commented Oct 21, 2016

guybedford commented Oct 25, 2016

oligot commented Oct 27, 2016

oligot commented Oct 27, 2016

guybedford commented Oct 27, 2016

oligot commented Oct 27, 2016

dot-prop 4.0.0 is written in ES2015 #985

dot-prop 4.0.0 is written in ES2015 #985

Conversation

oligot commented Oct 11, 2016

guybedford Oct 11, 2016

Choose a reason for hiding this comment

guybedford Oct 11, 2016

Choose a reason for hiding this comment

oligot Oct 11, 2016

Choose a reason for hiding this comment

guybedford commented Oct 11, 2016

oligot commented Oct 11, 2016

guybedford commented Oct 19, 2016

oligot commented Oct 20, 2016

guybedford commented Oct 20, 2016

oligot commented Oct 21, 2016

guybedford commented Oct 21, 2016

oligot commented Oct 21, 2016

guybedford commented Oct 21, 2016

oligot commented Oct 21, 2016

guybedford commented Oct 25, 2016

oligot commented Oct 27, 2016

oligot commented Oct 27, 2016

guybedford commented Oct 27, 2016

oligot commented Oct 27, 2016