Simplified Header.SetValue(string charset, string value) and added test

jstedfast · Jun 22, 2024 · 5bef376 · 5bef376
1 parent c6f9fd9
commit 5bef376
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 6 deletions.
diff --git a/MimeKit/Header.cs b/MimeKit/Header.cs
@@ -1542,12 +1542,7 @@ public void SetValue (FormatOptions format, string charset, string value)
 		/// </exception>
 		public void SetValue (string charset, string value)
 		{
-			if (charset is null)
-				throw new ArgumentNullException (nameof (charset));
-
-			var encoding = CharsetUtils.GetEncoding (charset);
-
-			SetValue (FormatOptions.Default, encoding, value);
+			SetValue (FormatOptions.Default, charset, value);
 		}
 
 		/// <summary>

diff --git a/UnitTests/HeaderTests.cs b/UnitTests/HeaderTests.cs
@@ -930,5 +930,19 @@ public void TestReformatDispositionNotificationOptions ()
 
 			Assert.That (result, Is.EqualTo (value));
 		}
+
+		[Test]
+		public void TestSetValueCharset ()
+		{
+			var expected = " =?gb18030?b?suLK1M7Esb4=?=" + FormatOptions.Default.NewLine;
+			var header = new Header ("Subject", "");
+
+			header.SetValue ("GB18030", "测试文本");
+
+			var raw = ByteArrayToString (header.RawValue);
+
+			Assert.That (raw[raw.Length - 1], Is.EqualTo ('\n'), "The RawValue does not end with a new line.");
+			Assert.That (raw, Is.EqualTo (expected), $"The encoded header does not match the expected value: {raw}");
+		}
 	}
 }