This repository has been archived by the owner on May 5, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 59
Custom logs with frame object as the 2nd param #55
Comments
Here is the promised PR - #56 |
Hey @JSteunou, what is your opinion? |
If I understand well you just need more info in the log like the content of a frame. I could do that, but not the way you did in your PR. |
@JSteunou I need to customize the data that is logged and the text is not the best fit. Of course, I don't mind if you do it in a different way. |
JSteunou
pushed a commit
that referenced
this issue
Oct 9, 2017
Could you test #58 and tell me if it matches your need? |
@JSteunou Right in the morning I'll check it! |
JSteunou
added a commit
that referenced
this issue
Oct 10, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Hi there,
this is a kind of a feature request. I am aware that it's possible to override the logs via
client.debug = (log) => ...myLogic
. It is cumbersome to do anything with the plain text. You could send the text and, as the 2nd parameter, the frame object. Then we developers can strip headers, shorten some access tokens, etc. ...At the moment the debug methods accepts a vararg
...args
. Every method in src/client.js is using only 1 arg (the message). See the code:I will create a PR in a moment so that you can verify it will make no harm, you'll see.
The text was updated successfully, but these errors were encountered: