Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature parity with OG ueberzug #86

Open
4 of 10 tasks
jstkdng opened this issue Jul 11, 2023 · 5 comments
Open
4 of 10 tasks

Feature parity with OG ueberzug #86

jstkdng opened this issue Jul 11, 2023 · 5 comments
Assignees
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@jstkdng
Copy link
Owner

jstkdng commented Jul 11, 2023

This is an issue to keep track of features that are availabe on ueberzug but aren't in ueberzugpp. If there's something else missing feel free to comment.

  • X11 output
  • Display multiple images at the same time
  • Json parser
  • Bash parser
  • Image scaler crop
  • Image scaler distort
  • Image scaler fit_contain
  • Image scaler contain
  • Image scaler forced_cover
  • Image scaler cover

Aditional comments

  • Only project that still uses the bash parsers that I could find is ucollage, looks pretty dead though
  • Partial implementation of the scalers fit_contain and forced_cover
  • Implementing the other scalers in a non-hacky way could require a large refactor
@jstkdng jstkdng added documentation Improvements or additions to documentation enhancement New feature or request labels Jul 11, 2023
@jstkdng jstkdng self-assigned this Jul 11, 2023
@jstkdng jstkdng pinned this issue Jul 11, 2023
@Tokariew
Copy link

https://github.com/munguua/ncmpcpp-ueberzug this project use bash parser and not json, but i ugly fixed in my fork

@jstkdng
Copy link
Owner Author

jstkdng commented Aug 16, 2023

https://github.com/munguua/ncmpcpp-ueberzug

not only is the project dead, it has issues disabled. I think it'd be better for you to improve your fork tbh.

@justchokingaround

This comment was marked as off-topic.

@jstkdng
Copy link
Owner Author

jstkdng commented Aug 19, 2023

i forgot this actually doesn't use uz++

bruh

@justchokingaround
Copy link
Contributor

this was the uz++ implemention i think. tho iirc it was a bit slow:

#!/bin/sh
set -e

max_width=45
max_height=45
preview_method="sixel"

cleanup() {
    ueberzugpp cmd -s "$UB_SOCKET" -a exit
}
trap cleanup HUP INT QUIT TERM PWR EXIT

UB_PID_FILE="/tmp/.$(uuidgen)"
ueberzugpp layer --no-cache -o "$preview_method" --no-stdin --silent --use-escape-codes --pid-file "$UB_PID_FILE"
UB_PID="$(cat "$UB_PID_FILE")"
export UB_SOCKET=/tmp/ueberzugpp-"$UB_PID".socket
while :; do
    title=$(playerctl metadata xesam:url 2>/dev/null | sed -nE "s@.*/(.*)\.(mp3|flac|opus|mkv|m4a)@\1@p")
    if [ -n "$title" ]; then
        path="$HOME/.cache/ncmpcpp/images/""$title.jpg"
        if [ "$old_path" != "$path" ]; then
            tput clear
            ueberzugpp cmd -s "$UB_SOCKET" -a add -i PREVIEW -x 0 -y 0 --max-width "$max_width" --max-height "$max_width" -f "$path"
        fi
        old_path="$path"
        sleep 2
    fi
done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants