-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not work in vifm #9
Comments
hey, just checked out that project and it is using some syntax seebye introduced before it died. Change this file https://github.com/thimc/vifmimg/blob/master/vifmimg#L9 and replace width and height with max_width and max_height. |
Just changed to max_width and max_height, but it still do not show image and stuck the program |
weird indeed, I'd recommend opening an issue in the vifmimg repository. |
I posted an issue in vifm, they said maybe it related to ueberzugpp command~ |
open an issue in the vifmimg repository, not vifm, vifm on its own has nothing to do with this project as far as I know. |
I open an issue in vifmimg. I temporarily changed to ranger, and it works fine with ueberzuggpp, thanks for your great work! |
As I've said, it's |
yeah, a PR should be made to pass regular numbers instead of strings. Adding more validations will slow down this program. If the owner of vifmimg doesn't respond I'll add them. |
I thought you'd want to change |
It is still the intention to be a drop-in replacement, I just didn't know how many other programs use the syntax that was introduced before, I was basing all my testing on ranger after all. |
@dongdongbh I've made some changes for vifm but it's still not working. Could you test the latest release? perhaps my vifm config is wrong |
I will test it next week and give feedback then |
Either that, I've also tried to use it in Vifm via a Lua plugin. It was a nice surprise that WMs without EWMH are supported, don't know if original ueberzug was able to do this too at some point, it didn't last time I tried. |
It works fine in my vifm with the last version, and yes, you should use PS: I also tested it on w3m, it not work in w3m. |
seems it doesn't even work with OG ueberzug. https://bbs.archlinux.org/viewtopic.php?id=269270 |
I didn't test the OG ueberzug, just saw people talking about it may use in w3m. In addition, it not work inside ssh, does this is the expected result? |
X11 forwarding would be required for that, and even then it might need some validation. |
I following vifmimg setup ueberzug for vifm. remove
-p json
in https://github.com/thimc/vifmimg/blob/6e4c562c302405c27f0de7c5c1a335ce1a5765e2/vifmrun#L16since -p json is not supported.
when I open a pdf file, their is a thumbnail picture created in cache directory, which proof the other part works fine, but it the image do not shows up in vifm, and the vifm stucked. When I open a image, their also no image shows up, and the vifm also stucked.
Test environment
system: ubuntu server 20.04
terminal: alacritty
vifm: v0.12.1
The text was updated successfully, but these errors were encountered: