Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace custom UTF-8 decoding in ChunkyByteArrayInputStream with JDK built-in #7

Closed
jstuyts opened this issue Apr 27, 2020 · 1 comment
Closed

Replace custom UTF-8 decoding in ChunkyByteArrayInputStream with JDK built-in #7

jstuyts opened this issue Apr 27, 2020 · 1 comment

Comments

@jstuyts
Copy link
Owner

jstuyts commented Apr 27, 2020 •
edited
Loading

The UTF-8 decoding in ChunkyByteArrayInputStream does not handle all code points. Use the standard decoding built into the JDK instead.

Also move the reading of character-based data out of the class, as it is an input stream and not a reader.
@jstuyts jstuyts changed the title Replace custom UTF-8 deconding in ChunkyByteArrayInputStream with JDK built-in Replace custom UTF-8 decoding in ChunkyByteArrayInputStream with JDK built-in Apr 28, 2020
@jstuyts
Copy link
Owner Author

jstuyts commented May 27, 2021

Extended code to handle characters encoded as 4 bytes. CharsetEncoder only works with ByteBuffer.

@jstuyts jstuyts closed this as completed May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jstuyts