-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modernize the code to Python 3.6+ #155
Conversation
Thanks! On the whole, I like the ideas here. But this PR introduces a lot of line-changes, spanning a few different suggestions, so it'll take me a little while to audit it. (I realize that many of the changes are auto-generated, but I'd still like to read them carefully.) |
Sorry for that huge diff. Would you like me to split different topics better into individual commits? That's a big change, but while the best moment to set formatting standards was at the beginning of the project, the second best is now.
|
I think it's fine to keep this PR as-is, but thanks for offering. I haven't forgotten about the PR, but have been busy. I hope to take a closer look soon. |
Now that we're at Python 3.6+, we can modernize the code and add f-strings,
pathlib.Path
and other Python3 features.Next steps would be to convert the tests to
pytest
. What do you think?