Added emoji from stickers implementation #40
Conversation
… debug stuff moved to bus.js
ghost
mentioned this pull request
| const telegram = global.telegram = require('./bots/telegram'); | ||
| Object.keys(bots).forEach(k => { | ||
| global[k] = bots[k]; | ||
| }); |
There was a problem hiding this comment.
Do we really need to store bots in global variables? I can't see where are they used.
There was a problem hiding this comment.
Already discussed and deleted those globals
| @@ -0,0 +1,2 @@ | |||
| const xmpp = Symbol.for('XMPP'); | |||
| module.exports = xmpp; | |||
There was a problem hiding this comment.
Just an idea: let's place all the networks in a single file? I can't see a reason to keep a bunch of files 2 lines long.
There was a problem hiding this comment.
The idea was that outside world doesn't need to know anything about the kind of network, this is needed just to skip double handling of messages sent through bus.
|
|
||
| return msg.first_name; | ||
| } | ||
| } |
There was a problem hiding this comment.
Honestly that looks strange. I can't see why you need a class for that single static function.
There was a problem hiding this comment.
This is done this way for having common interface for all *Message classes, code with similar logic is static and named as test is a part of other messages types. These kinds of methods are for checking if Telegram message could be transformed to our class, we can rename them all or re-structure as non-statics or whatever but in such case this change should be applied to all methods of this kind
|
Thanks for your contribution, everything is okay. I'm merging that. |
No description provided.