Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add banks for EastWest Hollywood Opus #211

Merged
merged 1 commit into from
Sep 21, 2024
Merged

Conversation

xshill
Copy link
Contributor

@xshill xshill commented Jun 4, 2023

I created some user banks for the EastWest Hollywood Opus edition keyswitches. The ones we already had in the repo were for the Play engine, and the keyswitch instruments that come with the Opus engine are different.

@gbombadil
Copy link

From what I could check my version has all available articulations while his has only the ones that came with the default Keyswitch instrument. Thats true at least for Woodwinds.
MyVersion
HisVersion

@jtackaberry
Copy link
Owner

@xshill can you confirm? Is #212 a superset of your PR? I don't have this library so there may be considerations I'm not aware of.

Thanks!

@gbombadil
Copy link

Hello, just checking, how much time of waiting is appropiate in this cases?

Thanks in advance....

@xshill
Copy link
Contributor Author

xshill commented Dec 21, 2023

@xshill can you confirm? Is #212 a superset of your PR? I don't have this library so there may be considerations I'm not aware of.

Thanks!

Holy crap, I'm so sorry about the late reply; Github never notified me or anything and I completely forgot to check back on this PR.

I took a quick look and it does indeed look like it implements more articulations that mine does (I only did the default articulations for keyswitch instruments, as mentioned).

Thanks @gbombadil !

Edit: I just realized it's only for woodwinds. So I think we can just replace the file userbanks/EastWest_Hollywood_Opus_Woodwinds.reabank with the bank that @gbombadil made, and keep the rest.

@jtackaberry jtackaberry merged commit 5a9873c into jtackaberry:master Sep 21, 2024
jtackaberry added a commit that referenced this pull request Sep 21, 2024
This is a more fleshed out bank. Following @xshill's suggestion in #211
to replace this bank from #212.

Fixes #212.
@jtackaberry
Copy link
Owner

jtackaberry commented Sep 21, 2024

Very sorry for the inexcusably slow turnaround time on this one. I've renamed the top-level group from EastWest to EastWest Quantum Leap so it's consistent with other EWQL userbanks in the collection.

And I've included @gbombadil's Woodwinds banks from #212, with some minor adjustments there so the patch naming is more consistent across the collection.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants