forked from DefinitelyTyped/DefinitelyTyped
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge upstream typings. #1
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the createHmac function definition to accept KeyObject in addition to BinaryLike for the 'key' argument. Update the createDecipheriv function definition to accept CipherKey instead of BinaryLike for the 'key' argument.
* add types for loadable/server 5.12 * add types for loadable/server 5.12 * fix: change definition according to cr * fix: add test definitions
* feat(webpack-dev-middleware): update to v3.7 - v2 created - update configuration options to v3.7 https://github.com/webpack/webpack-dev-middleware/tree/v3.7.2#options Thanks! * fix(webpack-serve): fix v1 tests errors - `The types of 'dev.logLevel' are incompatible between these types` - `Types of property 'dev' are incompatible` Required to pass test for `webpack-dev-middleware` changes
* Update js-cookie types Calls to set return a string or undefined, not void, as seen here: https://github.com/js-cookie/js-cookie/blob/master/src/api.mjs#L7 https://github.com/js-cookie/js-cookie/blob/master/src/api.mjs#L47 * Update js-cookie tests
- definition file - tests to cover options for Browserify and Watchify https://github.com/nikku/karma-browserify#readme Thanks!
* add new type definition * add information comments * properly generate the files * address feedback * correct the package name
* css-selector-tokenizer: add types and tests * correct lint errors apparently, the IDE's tslint extension does not report dtslint's output. my bad. * Correct typo in tests
* Create types for [simple-icons] * Add missing final newline * Update CODEOWNERS * Revert a533981 * Use `export =` instead of `export default` as suggested by @PranavSenthilnathan * fix lint errors
* Update index.d.ts * fix tests * remove creditCardCVV method * add missing space
* Update for evernote v2.0.5 * Better types for evernote
The tests use Array.include, which is not available in Typescript before 3.5. I rewrote them to use Array.indexOf instead.
* Add stopword type definitions Project: https://github.com/fergiemcdowall/stopword * add @types/stopword * Fix blank after '{' * Add type comments and fix rule's code * Fix lint's rule * Fix return value of removeStopword's function * Update index.d.ts * Update index.d.ts * Update index.d.ts * Update index.d.ts
* [reactstrap]: Export Util.setGlobalCssModule * [reactstrap]: Rename utils file
Dependencies of workbox-sw v3 use types that are only defined in TS 3.0 and above.
* Add Slider component to types and test * Use correct syntax for adding definition authors
- `prefixIds` corrected - `sortDefsChildren` added - `convertEllipseToCircle` added - tests updated with plugins tests https://github.com/svg/svgo/releases/tag/v1.3.0 Thanks!
* add waitForConnect * remove trailing whitespace
* fix(rsocket-flowable): makes Single.error() generic * use never instead * . * .
* Changes type of buttonStyle and paginationStyle to ViewStyle * Remove obsolete type import * Update definitions by section
So that we can reuse them when declaring SimpleSchema arguments...
- type definition based on @microsoft/dotnet-js-interop - tests See: dotnet/aspnetcore#18902 /cc @ryanelian @mkArtakMSFT Thanks!
* parse-prefer-header: Allow null or undefined input * parse-prefer-header: More explicit return value typing * parse-prefer-header: amend contributor list * parse-prefer-header: Support ReadonlyArray argument * parse-prefer-header: Add separate tests for Array and ReadonlyArray
* [newrelic] adds waitForIdle option to #shutdown * add contributor note
* fix: add multi and toKey methods * fix: return pipeline without promise * test: add test * style: fix lint
Co-authored-by: VSCode <vscode@microsoft.com>
* Removing prompt verbage from selection binding options * office-js * office-js-preview
* feat(testing-library/dom): Add name option to byRole * Bump version
…, escapeQuerySpace, preventInvalidHostname (#43025) * added missing properties and methods: - duplicateQueryParameters - escapeQuerySpace - preventInvalidHostname * added author.
* update types * update test case * add test case * update version * update header Co-authored-by: aohua <aohua@percy.sg>
* fix(cesium): missing objects added - `MapboxStyleImageryProvider` https://cesium.com/docs/cesiumjs-ref-doc/MapboxStyleImageryProvider.html - `MapboxImageryProvider` https://cesium.com/docs/cesiumjs-ref-doc/MapboxImageryProvider.html Fixes: #42880 Thansk! * Revert version bump as per PR comment /cc @jrafidi
- added deprecated options that are still in the api, but not documented as public option anymore - documentation for `overrideBrowserslist` updated https://github.com/postcss/autoprefixer/blob/master/lib/autoprefixer.js#L68-L93 Thanks!
…tion (#42849) Co-authored-by: Cédric Taschereau <cedric.taschereau@boreal-is.com>
* [office-js-preview] (Outlook) Body.appendOnSend * Fix typo * Updates based on feedback * Tweaks * Removed cleanup tweaks based on feedback * Undo * Note how to clear call * Note append on send runs before ItemSend functionality
Co-authored-by: Sudhi <Murthy@sudhipro15.fios-router.home>
Remove "minimum TS" line since 2.3 has been deprecated.
* layui-layer * Update index.d.ts
* commit jquery-croper type definitions commit jquery-croper type definitions * Update index.d.ts Update index.d.ts, correcting the version of the cropper and remove unnecessary comments. * update tsconfig Adding "strictFunctionTypes": true to tsconfig.json file. * Update index.d.ts & tslint.json Removing declare module "jquery-cropper" { }, and fixing the Project url * update "interface-name" property set "interface-name" property to false in tslint.json * update tslint * remove the patch version from index.d.ts * update rules in tslint.json * completely remove the patch digit * remove "v" from MAJOR.MINOR * Update tslint.json enabled interface-name property * adjust interface-name rule adjust interface-name rule to "interface-name": [true, "never-prefix"] * remove I from interface name remove I from interface name * added new line to last line added new line to last line
* Add missing labelTextStyle * Update index.d.ts
- definition files - tests for global/CommonJS usage https://github.com/ElemeFE/obsolete-webpack-plugin/tree/master/packages/obsolete-web Thanks!
…pe Read mode only (#43048)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please fill in this template.
npm test
.)npm run lint package-name
(ortsc
if notslint.json
is present).Select one of these and delete the others:
If adding a new definition:
.d.ts
files generated via--declaration
dts-gen --dt
, not by basing it on an existing project.tslint.json
should be present and it shouldn't have any additional or disabling of rules. Just content as{ "extends": "dtslint/dt.json" }
. If for reason the some rule need to be disabled, disable it for that line using// tslint:disable-next-line [ruleName]
and not for whole package so that the need for disabling can be reviewed.tsconfig.json
should havenoImplicitAny
,noImplicitThis
,strictNullChecks
, andstrictFunctionTypes
set totrue
.If changing an existing definition:
tslint.json
containing{ "extends": "dtslint/dt.json" }
. If for reason the any rule need to be disabled, disable it for that line using// tslint:disable-next-line [ruleName]
and not for whole package so that the need for disabling can be reviewed.If removing a declaration:
notNeededPackages.json
.