Add Pod lifecycle to remove redirect iptables rule #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement Pod lifecycle to remove redirect iptables rules to avoid traffic be redirected to one port service that is not working anymore. It is implemented using Pod Lifecycle preStop to remove the rule when the kube2iam DaemonSet is deleted or the pod die somehow.
jtblin
reviewed
Dec 21, 2020
| @@ -152,6 +152,12 @@ different than `docker0` depending on which virtual network you use e.g. | |||
| * for [OpenShift](https://www.openshift.org/) use `tun0` | |||
| * for [Cilium](https://www.cilium.io) use `lxc+` | |||
|
|
|||
| **Warning**: It is important ensure the iptables rule will be deleted when you delete the DaemonSet. Below is the command proposal to deal with it, we recommend to use the comand in the Pod Lifecycle: | |||
|
cc @mariusv @walkafwalka can you help reviewing helm charts changes pls? |
mariusv
requested changes
Dec 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement Pod lifecycle to remove redirect iptables rules to avoid
traffic be redirected to one port service that is not working anymore.
It is implemented using Pod Lifecycle preStop to remove the rule when
the kube2iam DaemonSet is deleted or the pod die somehow.