Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem with allocPTPage() in SVA/lib/mmu.c #10

Closed
XiaowanDong opened this issue Jul 20, 2017 · 3 comments
Closed

Problem with allocPTPage() in SVA/lib/mmu.c #10

XiaowanDong opened this issue Jul 20, 2017 · 3 comments

Comments

@XiaowanDong
Copy link
Contributor

  1. Here https://github.com/XiaowanDong/SVA/blob/master/SVA/lib/mmu.c#L1006, p is a pointer, so it should be compared against NULL instead of 0.
  2. This line https://github.com/XiaowanDong/SVA/blob/master/SVA/lib/mmu.c#L1030 should be moved into the if statement above it.
@jtcriswell
Copy link
Owner

Correct and correct. Please make the necessary changes, test them, and commit.

@XiaowanDong
Copy link
Contributor Author

XiaowanDong commented Jul 20, 2017 via email

jtcriswell added a commit that referenced this issue Jul 20, 2017
@jtcriswell
Fixed Issue 10: #10.
40c6e6a 
Fixed Issue 10 (#10).

Modified the code to compare a pointer against NULL instead of
against zero.

Modified code that sets the ghostPTP flag for a memory frame so
that it is set only when a free frame is found.
@jtcriswell
Copy link
Owner

Fixed in Revision 40c6e6a.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jtcriswell @XiaowanDong