Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Types.renderBS should recognize line breaks #5

Closed
coreyoconnor opened this issue Mar 16, 2011 · 2 comments
Closed

Types.renderBS should recognize line breaks #5

coreyoconnor opened this issue Mar 16, 2011 · 2 comments

Comments

@coreyoconnor
Copy link
Contributor

From Simon Michael: "I expected renderBS to convert a multiline string into an Image of height > 1."

@jtdaugherty
Copy link
Owner

I notice that

  • renderBS is now utf8Bytestring
  • string and text also lack the above described behavior

For instance, to render a multiline string I essentially always do

vertCat $ string <$> lines s

Do you think this change is worth making? Given my experience with vty-ui and brick I'd say it would be useful to make the string-rendering functions handle newlines in a reasonable way, but it could also be a breaking change.

@jtdaugherty
Copy link
Owner

(Also, given the lack of other requests for this behavior, it could also be reasonable to just close this as unimportant.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants