Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it possible to move away from V8 in favor of a liter dependency? Say, QuickJSR #81

Open
barracuda156 opened this issue Oct 11, 2023 · 4 comments

Comments

@barracuda156
Copy link

@jtextor V8 is a very heavy dependency to build and it is broken for some platforms. Could we get rid of it? Possibly, replacing with QuickJSR, like rstan did?

@jtextor
Copy link
Owner

jtextor commented Oct 11, 2023

It's an interesting idea, but V8 is very fast and QuickJS seems to be quite a bit slower ... I don't know if that would be a bottleneck or not? Could be an interesting thing to test.

@barracuda156
Copy link
Author

I cannot vouch personally for speed (since V8 is broken for the platform where I test), but given that rstan uses QuickJSR, and rstan is a very sophisticated and speed-wanting software, it should be pretty good.

QuickJSR itself builds quickly, and Stan models work fine. V8 – well, last time I tried to fix it, and went pretty far with that, it took multiple hours before failing on a wrong assembler :) Admittedly, my PowerPC is no TALOSII, but it is a very heavy dependency.

@barracuda156
Copy link
Author

@jtextor Maybe you could make a branch with a switch to QuickJSR? That would fix dagitty without compromising it for those preferring V8.

@barracuda156
Copy link
Author

@jtextor Any update on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants