Skip to content

Commit

Permalink
Revert of plugins/update-widgets-crash.html victim element goes missi…
Browse files Browse the repository at this point in the history
…ng (patchset #1 id:1 of https://codereview.chromium.org/1122483002/)

Reason for revert:
Didn't quite fix the issue: same failure appeared on the build bots.  Reverting here to fix via TestExpectations instead.

Original issue's description:
> plugins/update-widgets-crash.html victim element goes missing
> 
> The victim element to be removed is non-existant sometimes after the bugs
> listed resolved. Workaround for now, by testing that the "victim" element
> exists to avoid an exception, which causes extra test console output, and
> fails the test. See issue 476590 #46 for a bot failure example.
> 
> TBR=haraken@chromium.org
> BUG=457054, 476590
> NOTRY=true
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194807

TBR=haraken@chromium.org,bbudge@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=457054, 476590

Review URL: https://codereview.chromium.org/1120963002

git-svn-id: svn://svn.chromium.org/blink/trunk@194809 bbb929c8-8fbe-4397-9dbb-9b2b20218538
  • Loading branch information
noel@chromium.org committed May 1, 2015
1 parent 148fcb5 commit f66ae1e
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions LayoutTests/plugins/update-widgets-crash.html
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,7 @@
return;

var victim = document.getElementById('victim');
if (victim)
victim.parentNode.removeChild(victim);
victim.parentNode.removeChild(victim);
document.body.offsetTop;

if (window.testRunner)
Expand Down

0 comments on commit f66ae1e

Please sign in to comment.