Nw13 #1
Merged
Nw13 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Consumers of WebTouchEvents may expect that the touches are in the same order from one event to the next. WebTouchEventBuilder is encountered in some pathways but not others (e.g. WebTouchEvents passed to plugins go through WebTouchEventBuilder). This CL sorts the touches in WebTouchEvents that are constructed by WebTouchEventBuilder. BUG=463747 Review URL: https://codereview.chromium.org/1132643002 git-svn-id: svn://svn.chromium.org/blink/trunk@195224 bbb929c8-8fbe-4397-9dbb-9b2b20218538
…id:1 of https://codereview.chromium.org/1086983007/) Reason for revert: This apparently produces behavior that diverges from Firefox. Reverting until I can track that down, just to make sure we don't ship a broken M44. BUG=482812 Original issue's description: > Ship the ancestor restriction to 'first-party'. > > https://www.chromestatus.com/features/5592111340584960 > > Intent to Ship: https://groups.google.com/a/chromium.org/d/msg/blink-dev/ZvMEJMSU6po/KDnS4ES9L8kJ > > BUG=477578 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194121 TBR=jochen@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=477578 Review URL: https://codereview.chromium.org/1138063004 git-svn-id: svn://svn.chromium.org/blink/trunk@195225 bbb929c8-8fbe-4397-9dbb-9b2b20218538
BUG=337688 R=scheib@chromium.org Review URL: https://codereview.chromium.org/1139613002 git-svn-id: svn://svn.chromium.org/blink/trunk@195226 bbb929c8-8fbe-4397-9dbb-9b2b20218538
Except for inspector related code. BUG=462402 Review URL: https://codereview.chromium.org/1085113006 git-svn-id: svn://svn.chromium.org/blink/trunk@195227 bbb929c8-8fbe-4397-9dbb-9b2b20218538
R=pfeldman@chromium.org BUG= Review URL: https://codereview.chromium.org/1131723005 git-svn-id: svn://svn.chromium.org/blink/trunk@195228 bbb929c8-8fbe-4397-9dbb-9b2b20218538
…t timings This change fixes an ASAN use-after-free crash when running two animations that share the same @Keyframes name on the same element with different timings during a style update. This scenario rides on an existing bug where we only store the last animation for a given @Keyframes name per element but process updates for each specified animation on the same animation. This caused a scenario where updates that replaced the KeyframeEffectModel were also triggering synthetic keyframe updates on the same animation. The ordering of these updates left a dangling RawPtr that was then used in appropriately when updating expired synthetic keyframes. BUG=484614 Review URL: https://codereview.chromium.org/1136203002 git-svn-id: svn://svn.chromium.org/blink/trunk@195229 bbb929c8-8fbe-4397-9dbb-9b2b20218538
Fix up some minor fall out from the big Animation rename: https://codereview.chromium.org/1113173003 BUG=483272 Review URL: https://codereview.chromium.org/1138833004 git-svn-id: svn://svn.chromium.org/blink/trunk@195230 bbb929c8-8fbe-4397-9dbb-9b2b20218538
…isible for WorkerThreadTest. Fix the following undefined reference error: Source/core/workers/WorkerThreadTest.cpp:72: error: undefined reference to 'blink::EventTargetNames::DedicatedWorkerGlobalScope'. BUG=358074 Review URL: https://codereview.chromium.org/1123373004 git-svn-id: svn://svn.chromium.org/blink/trunk@195231 bbb929c8-8fbe-4397-9dbb-9b2b20218538
This removes ScriptedSpeech and SessionStorage runtime enabled feature flags. These flags are not used anywhere in the code and have not been touched for ~2 years. This is a trivial clean up patch with no behaviour changes. Review URL: https://codereview.chromium.org/1130053005 git-svn-id: svn://svn.chromium.org/blink/trunk@195232 bbb929c8-8fbe-4397-9dbb-9b2b20218538
TBR=fmalita@chromium.org BUG=445598 Review URL: https://codereview.chromium.org/1134183002 git-svn-id: svn://svn.chromium.org/blink/trunk@195233 bbb929c8-8fbe-4397-9dbb-9b2b20218538
This reverts commit 02b86af. Assuming http://crrev.com/1098233003 fixed the crash issue, we no longer need this trap, I think. BUG=475880 Review URL: https://codereview.chromium.org/1100413005 git-svn-id: svn://svn.chromium.org/blink/trunk@195234 bbb929c8-8fbe-4397-9dbb-9b2b20218538
This test will help to ensure current behavior isn't altered while removing the timer heap. Original patch by Alex Clarke <alexclarke@chromium.org>. BUG=463143 Review URL: https://codereview.chromium.org/1130423002 git-svn-id: svn://svn.chromium.org/blink/trunk@195235 bbb929c8-8fbe-4397-9dbb-9b2b20218538
A second attempt to land https://codereview.chromium.org/1138743002/ In order to support preconnect for both anonymous and non-anonymous connection pools we need to add support for the crossorigin attribute in <link rel=preconnect>. This CL implements the core functionality of this change on the Blink side. BUG=468005 Review URL: https://codereview.chromium.org/1135203002 git-svn-id: svn://svn.chromium.org/blink/trunk@195236 bbb929c8-8fbe-4397-9dbb-9b2b20218538
BUG=486762 Review URL: https://codereview.chromium.org/1127263003 git-svn-id: svn://svn.chromium.org/blink/trunk@195237 bbb929c8-8fbe-4397-9dbb-9b2b20218538
…tor tab The patch extends TabbedPaneTabDelegate with onContextMenu method and fullfills the context menu from inside TabbedEditorContainer. BUG=481003 R=pfeldman@chromium.org Review URL: https://codereview.chromium.org/1128333004 git-svn-id: svn://svn.chromium.org/blink/trunk@195238 bbb929c8-8fbe-4397-9dbb-9b2b20218538
Migrate file-system-project.html from MockIsolatedFileSystem to InspectorTest.TestFileSystem. BUG=466529 R=pfeldman@chromium.org Review URL: https://codereview.chromium.org/1140433002 git-svn-id: svn://svn.chromium.org/blink/trunk@195239 bbb929c8-8fbe-4397-9dbb-9b2b20218538
http://src.chromium.org/viewvc/blink?view=revision&revision=195233 BUG=445598 TBR=fs@opera.com Review URL: https://codereview.chromium.org/1125163003 git-svn-id: svn://svn.chromium.org/blink/trunk@195240 bbb929c8-8fbe-4397-9dbb-9b2b20218538
TBR=dgozman BUG=487084 Review URL: https://codereview.chromium.org/1138063005 git-svn-id: svn://svn.chromium.org/blink/trunk@195241 bbb929c8-8fbe-4397-9dbb-9b2b20218538
…Buffer methods pure virtual. This has to be submitted only after the Chromium change lands. Blink CL: https://codereview.chromium.org/1002293005/ Chromium CL: https://codereview.chromium.org/1037483003/ BUG=459008 Review URL: https://codereview.chromium.org/1131913002 git-svn-id: svn://svn.chromium.org/blink/trunk@195242 bbb929c8-8fbe-4397-9dbb-9b2b20218538
Original patch by Alex Clarke <alexclarke@chromium.org>. BUG=463143 Review URL: https://codereview.chromium.org/1130413003 git-svn-id: svn://svn.chromium.org/blink/trunk@195243 bbb929c8-8fbe-4397-9dbb-9b2b20218538
V8EventLazyListener change for v8::isolate as first argument , As v8::isolate is not a optional argument anymore BUG=424446 Review URL: https://codereview.chromium.org/1140613005 git-svn-id: svn://svn.chromium.org/blink/trunk@195244 bbb929c8-8fbe-4397-9dbb-9b2b20218538
R=sergeyv BUG=481887 Review URL: https://codereview.chromium.org/1130153006 git-svn-id: svn://svn.chromium.org/blink/trunk@195246 bbb929c8-8fbe-4397-9dbb-9b2b20218538
Restore webtiming-origins.html test. Modify it to reproduce the issue with redirect count. BUG=485015 Review URL: https://codereview.chromium.org/1128003002 git-svn-id: svn://svn.chromium.org/blink/trunk@195248 bbb929c8-8fbe-4397-9dbb-9b2b20218538
BUG= Review URL: https://codereview.chromium.org/1137143002 git-svn-id: svn://svn.chromium.org/blink/trunk@195249 bbb929c8-8fbe-4397-9dbb-9b2b20218538
If an overloaded method is partially runtime enabled such that its "longest" overload(s) might be disabled, we need to determine the maximum distinguishing argument index runtime, to avoid using an index for which all actual overloads are disabled, since that would typically cause us to incorrectly reject the call as not matching any overload. The implementation is largely a copy of the existing and very similar runtime determination of the correct Function.length value. While we're at it, drop the overloads['minarg'] value, which was just a less accurate variant of overloads['length'] used in a few places where it didn't really matter anyway. BUG=486249 Review URL: https://codereview.chromium.org/1132243004 git-svn-id: svn://svn.chromium.org/blink/trunk@195251 bbb929c8-8fbe-4397-9dbb-9b2b20218538
BUG=485884 Review URL: https://codereview.chromium.org/1129383005 git-svn-id: svn://svn.chromium.org/blink/trunk@195252 bbb929c8-8fbe-4397-9dbb-9b2b20218538
…ed resources. Invalid URLs are treated as insecure now. (https://codereview.chromium.org/1003273009) |originalURLViaServiceWorker| of the SW generated resource is empty. But we should treat it as secure. So this CL skips the Mixed Content and CSP checking for the ServiceWorker generated resources. BUG=478207 Review URL: https://codereview.chromium.org/1084323006 git-svn-id: svn://svn.chromium.org/blink/trunk@195253 bbb929c8-8fbe-4397-9dbb-9b2b20218538
BUG=402536 Review URL: https://codereview.chromium.org/1122403007 git-svn-id: svn://svn.chromium.org/blink/trunk@195256 bbb929c8-8fbe-4397-9dbb-9b2b20218538
BUG=481824 Review URL: https://codereview.chromium.org/1140623003 git-svn-id: svn://svn.chromium.org/blink/trunk@195258 bbb929c8-8fbe-4397-9dbb-9b2b20218538
This patch updates the fast/css/ex-unit-with-no-x-height.html test for when an x-height is missing. We are technically following the spec in synthesizing an xHeight value but there are platform specific differences that prevent these values from being equal across all platforms. The spec allows for any heuristic other than returning no x-height: http://dev.w3.org/csswg/css-values-3/#font-relative-lengths. BUG=487170 Review URL: https://codereview.chromium.org/1140693002 git-svn-id: svn://svn.chromium.org/blink/trunk@195259 bbb929c8-8fbe-4397-9dbb-9b2b20218538
> Allow lax MIME type parsing for same-origin CSS in quirks mode. > > The change in [1] is too strict for the web, and doesn't match Firefox > or IE's behavior. In particular, it does not respect the same-origin > carveout that the HTML spec specifies[2]. > > This patch corrects that oversight. > > [1]: https://chromium.googlesource.com/chromium/blink/+/80f95a77030f72e9502f52873eeb4490c4b3f458 > [2]: https://html.spec.whatwg.org/multipage/semantics.html#link-type-stylesheet > > BUG=495711 > > Review URL: https://codereview.chromium.org/1169713004 TBR=mkwst@chromium.org Review URL: https://codereview.chromium.org/1180763002 git-svn-id: svn://svn.chromium.org/blink/branches/chromium/2403@196916 bbb929c8-8fbe-4397-9dbb-9b2b20218538
> Improving direction-based selection strategy. > > This implements two improvements to the direction-based selection strategy: > 1. The "offset": > If the selection expands beyond extent (in word granularity) and then the user > shrinks the selection - previously the granularity would change to character and > the end of the selection would jump to the extent, so the visible selection could > change quite significantly even if the user moved the extent by a little bit. Now > the selection only changes by the amount the user moved the extent from previous > position. Effectively we are saving the delta between extent and the visible > start/end in word granularity and preserving it as we switch to character granularity. > > 2. When the selection is expanding, previously we would expand the selection to the > end of the word as soon as the extent moved beyond the first word character. This is > the default behavior of Word granularity. With the new behavior, we only expand > the selection to the end of the word when the extent moves beyond the middle of the word. > > More details in comments to DirectionGranularityStrategy in GranularityStrategy.h > > BUG=451255 > > Review URL: https://codereview.chromium.org/1123563003 TBR=mfomitchev@chromium.org, leviw, aelias, yosin Review URL: https://codereview.chromium.org/1181713002 git-svn-id: svn://svn.chromium.org/blink/branches/chromium/2403@196959 bbb929c8-8fbe-4397-9dbb-9b2b20218538
> Deprecate the allowfullscreen exemption for <video> > > BUG=496637 > > Review URL: https://codereview.chromium.org/1165013002 TBR=philipj@opera.com Review URL: https://codereview.chromium.org/1176403004 git-svn-id: svn://svn.chromium.org/blink/branches/chromium/2403@196972 bbb929c8-8fbe-4397-9dbb-9b2b20218538
…l times. (patchset #4 id:60001 of https://codereview.chromium.org/1138583002/) Reason for revert: Going to disable --harmony-tostring until our bindings have been updated. Original issue's description: > Make Window.prototype.toString return [object Window] at all times. > > The old code was incorrectly falling back to > Object.prototype.toString.call which does not work as expected without > full support for @@toSringTag > > BUG=239915 > R=adamk, jsbell > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195193 TBR=adamk@chromium.org,jsbell@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=239915 Review URL: https://codereview.chromium.org/1163943002 (cherry picked from commit 4958fd9) Review URL: https://codereview.chromium.org/1182643002. git-svn-id: svn://svn.chromium.org/blink/branches/chromium/2403@196974 bbb929c8-8fbe-4397-9dbb-9b2b20218538
> Fix crash when an onorientationchange event detaches an iframe. > > Collect all of the frames that need onorientationchange before firing any of the events. If a frame gets detached, frame->localDOMWindow()->frame() will be null, and the recursive invocation will crash. > > BUG=492432,466485 > TEST=WebFrameTest.OrientationFrameDetach > > Review URL: https://codereview.chromium.org/1172603004 TBR=japhet@chromium.org Review URL: https://codereview.chromium.org/1187563002 git-svn-id: svn://svn.chromium.org/blink/branches/chromium/2403@197059 bbb929c8-8fbe-4397-9dbb-9b2b20218538
> Revert of DevTools: NetworkPanel: Preview: do not try to show HTML as JSONP. (patchset #1 id:1 of https://codereview.chromium.org/973813003/) > > Reason for revert: > See https://code.google.com/p/chromium/issues/detail?id=492540 > > Original issue's description: > > DevTools: NetworkPanel: Preview: do not try to show HTML as JSONP. > > > > BUG= > > > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=191295 > > TBR=eustas@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true BUG=492540 > > Review URL: https://codereview.chromium.org/1148133004 TBR=pfeldman@chromium.org Review URL: https://codereview.chromium.org/1190553002 git-svn-id: svn://svn.chromium.org/blink/branches/chromium/2403@197122 bbb929c8-8fbe-4397-9dbb-9b2b20218538
> New SELECT Popup: Recalc style when a web font is loaded > > PopupMenuCSSFontSelector should relay the invalidation callback from m_ownerFontSelector so the style willbe recalculated when a font loads on the owner page. > > BUG=481515 > > Review URL: https://codereview.chromium.org/1159833003 TBR=keishi@chromium.org Review URL: https://codereview.chromium.org/1188563006 git-svn-id: svn://svn.chromium.org/blink/branches/chromium/2403@197137 bbb929c8-8fbe-4397-9dbb-9b2b20218538
> Click event should be fired before change events for checkbox and radio button. > > This cl fixes this issue. > > Bug=178505 > > Review URL: https://codereview.chromium.org/842153002 TBR=paritosh.in@samsung.com BUG=178505, 500084 Review URL: https://codereview.chromium.org/1190633002 git-svn-id: svn://svn.chromium.org/blink/branches/chromium/2403@197148 bbb929c8-8fbe-4397-9dbb-9b2b20218538
> Correctly send the 'HTTPS' header for top-level navigations. > > We don't have an active Document during top-level navigation, which I > didn't account for when adding the 'HTTPS' header. This patch adjusts > the expectations to match reality. > > BUG=495991 > > Review URL: https://codereview.chromium.org/1178093002 TBR=mkwst@chromium.org Review URL: https://codereview.chromium.org/1186193003 git-svn-id: svn://svn.chromium.org/blink/branches/chromium/2403@197163 bbb929c8-8fbe-4397-9dbb-9b2b20218538
…cks. The page itself must control where the fragment to match ends, otherwise leading-substring matches may be induced. The pre-conditions required for this are expected to be uncommon. BUG=498982 Review URL: https://codereview.chromium.org/1179633002 (cherry picked from commit 52e2a37) Review URL: https://codereview.chromium.org/1190433008. git-svn-id: svn://svn.chromium.org/blink/branches/chromium/2403@197177 bbb929c8-8fbe-4397-9dbb-9b2b20218538
> bindings: Supports serializer for PerformanceTiming. > > Although the spec doesn't have a serializer in PerformanceTiming, > Chrome (til M42) and IE supported a serializer and FF followed them. > Considering the nature of PerformanceTiming, it's quite natural to have > a serializer. > > Let's support JSON.stringify (again) for PerformanceTiming. > > BUG=497900 > > Review URL: https://codereview.chromium.org/1171893004 TBR=yukishiino@chromium.org Review URL: https://codereview.chromium.org/1183553003 git-svn-id: svn://svn.chromium.org/blink/branches/chromium/2403@197332 bbb929c8-8fbe-4397-9dbb-9b2b20218538
> Check whether the shadow page has been loaded in WebEmbeddedWorkerImpl::terminateWorkerContext(). > > WebEmbeddedWorkerImpl::terminateWorkerContext() could be called between > loadShadowPage() and didFinishDocumentLoad(). But the current code doesn't > handle this situation correctly. > > BUG=499646,497029 > > Review URL: https://codereview.chromium.org/1187813010 TBR=horo@chromium.org Review URL: https://codereview.chromium.org/1184663003 git-svn-id: svn://svn.chromium.org/blink/branches/chromium/2403@197338 bbb929c8-8fbe-4397-9dbb-9b2b20218538
> Avoid resetting rule features when removing style-less shadow. > > We reset the global rule features when removing a shadow root from the > tree. There is no reason to do that if the scope does not contain style, > so we'll skip the reset when there is no ScopedStyleResolver. > > In particular, this can be the case for UA shadow roots. For the case > where the scope contains style, this will be fixed by componentized style > resolving. > > What occurs in issue 499349 is: > > 1. Remove a form child which is an input with a UA shadow root. > 2. Removing the root causes rule features to be reset globally. > 3. Removing an input child of a form requires a validity check. > 4. The validity check schedules an invalidation for :valid etc. > 5. Scheduling invalidation sets require an up-to-date rule feature set > which includes invalidation sets, so the rule features are collected. > > 1-5 is repeated for each removed input. The global feature collection in > step 5 is the expensive part here. > > R=tkent@chromium.org,esprehn@chromium.org > BUG=499349 > > Review URL: https://codereview.chromium.org/1185423004 TBR=rune@opera.com Review URL: https://codereview.chromium.org/1173343010 git-svn-id: svn://svn.chromium.org/blink/branches/chromium/2403@197408 bbb929c8-8fbe-4397-9dbb-9b2b20218538
> DevTools: editor should not loose scroll position when displaying inline values > > The bug happens due to the following reasons: > a) CodeMirror requires manual scroll restoring after it is attached to DOM. > It is usually done via "refresh" method call, but we optimize this and > restore scroll position via custom super-fast logic, written in > CodeMirrorTExtEditor.onResize. > > b) if a codeMirror.operation is called on unitialized CodeMirror instance, then > scroll position is lost. > > This patch post-pones inline value processing until textEditor is > initialized. > > BUG=499889 > R=pfeldman > > Review URL: https://codereview.chromium.org/1178063005 TBR=lushnikov@chromium.org Review URL: https://codereview.chromium.org/1194923002 git-svn-id: svn://svn.chromium.org/blink/branches/chromium/2403@197472 bbb929c8-8fbe-4397-9dbb-9b2b20218538
> Have ScreenOrientationController use a timer for async event dispatch again > > Essentially revert r193927's switch to using a task to queue handling of > change event dispatch for ScreenOrientationController. Queuing a task > via the execution context / Document is unsafe for this controller object > as its lifetime is that of its frame. Should the frame be detached and > finalized while the Document remains alive, the queued task risks accessing > a freed ScreenOrientationController upon running. > > Go back to using a one-shot timer; as these are now task based, the > original motivation for r193927 has additionally fallen away (wean Blink > off from using one-shot shared timers.) > > R=mlamouri > BUG=501888 > > Review URL: https://codereview.chromium.org/1190293002 TBR=sigbjornf@opera.com Review URL: https://codereview.chromium.org/1195063003 git-svn-id: svn://svn.chromium.org/blink/branches/chromium/2403@197495 bbb929c8-8fbe-4397-9dbb-9b2b20218538
> DevTools: properly reset ignoreExecutionLine flag > > The ignoreExecutionLine flag might be stuck after failed LiveEdit. > > BUG=478369 > R=pfeldman > > Review URL: https://codereview.chromium.org/1191383002 TBR=lushnikov@chromium.org Review URL: https://codereview.chromium.org/1194073004 git-svn-id: svn://svn.chromium.org/blink/branches/chromium/2403@197572 bbb929c8-8fbe-4397-9dbb-9b2b20218538
> Rebuild GraphicsLayer tree when a LayoutPart's CDPLM configuration changes > > When a CompositedDeprecatedPaintLayerMapping's internal configuration > changes, the GraphicsLayer tree is rebuilt so that the CDPLM's > GraphicsLayers are reconnected to ancestors and descendants. However, > for CDPLMs owned by LayoutParts, the decision to rebuild ignores > whether the CDPLMs internal configuration has changed. This means that > after an internal configuration change (e.g., the removal of an ancestor > clipping layer), such a CDPLM's GraphicsLayers can be left disconnected > from the rest of the GraphicsLayer tree. This CL rebuilds the > GraphicsLayer tree when such a CDPLM's internal configuration changes. > > BUG=497271 > > Review URL: https://codereview.chromium.org/1181743003 TBR=ajuma@chromium.org Review URL: https://codereview.chromium.org/1198423003 git-svn-id: svn://svn.chromium.org/blink/branches/chromium/2403@197583 bbb929c8-8fbe-4397-9dbb-9b2b20218538
fix crash in new-win-policy test
jtg-gg
pushed a commit
that referenced
this pull request
Jul 31, 2015
jtg-gg
pushed a commit
that referenced
this pull request
Jul 31, 2015
…object. (patchset #1 id:1 of https://codereview.chromium.org/1096393005/) Reason for revert: Speculative revert for RenderFrameImplTest failures blocking Blink roll http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_asan_rel/builds/58952 Original issue's description: > Initialize the new WindowProxy when handing off the global object. > > BUG=480676 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194405 TBR=haraken@chromium.org,dcheng@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=480676 Review URL: https://codereview.chromium.org/1078983007 git-svn-id: svn://svn.chromium.org/blink/trunk@194464 bbb929c8-8fbe-4397-9dbb-9b2b20218538
jtg-gg
pushed a commit
that referenced
this pull request
Jul 31, 2015
…teStyle test (patchset #1 id:1 of https://codereview.chromium.org/1067513005/) Reason for revert: Enable test. Original issue's description: > Disable WebViewTest.cpp::ShowUnhandledTapUIIfNeededWithMutateStyle test. > > The test fails only on the M42 branch but works on ToT and other newer branches. > This doesn't test critical functionality so just disable it. > > This CL is only for branch fixing. After merge, I will enable this test. > > BUG=465725 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194093 TBR=tkent@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=465725 Review URL: https://codereview.chromium.org/1104963002 git-svn-id: svn://svn.chromium.org/blink/trunk@194483 bbb929c8-8fbe-4397-9dbb-9b2b20218538
jtg-gg
pushed a commit
that referenced
this pull request
Jul 31, 2015
The current BackgroundBleedShrinkBackground implementation peeks at the CTM for two reasons: 1) to decide whether it is safe to use this strategy (border width >= 2px in device space) 2) to compute a background inset value corresponding to 1px in device space The latter can be changed to always inset to to middle of the outer border ring (1/2 border width for filled border styles, 1/6 border width for double borders). A potential solution for #1 is to simply drop the minimum device space border width check: if the border is so thin (< 2px), then we'll get all kinds of backdrop bleeding along its corners anyway - but these artifacts are not going to be noticeable to the naked eye. BackgroundBleedShrinkBackground is still the most efficient bleed avoidance strategy (draws common borders as a simple stroked rrect), and with these two changes it becomes usable with Slimming Paint - but also for thin/1px non-SP borders. BUG=445598,382491,478796 R=junov@chromium.org,chrishtr@chromium.org Review URL: https://codereview.chromium.org/1089313003 git-svn-id: svn://svn.chromium.org/blink/trunk@194623 bbb929c8-8fbe-4397-9dbb-9b2b20218538
jtg-gg
pushed a commit
that referenced
this pull request
Jul 31, 2015
…iew.chromium.org/1115623002/) Reason for revert: We can't remove blink:: here. Original issue's description: > Removing blink::prefix > > Removing blink::prefix in Source/build/* whereever it is not needed. > > BUG=477256 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194651 TBR=haraken@chromium.org,a.berwal@samsung.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=477256 Review URL: https://codereview.chromium.org/1115603005 git-svn-id: svn://svn.chromium.org/blink/trunk@194670 bbb929c8-8fbe-4397-9dbb-9b2b20218538
jtg-gg
pushed a commit
that referenced
this pull request
Jul 31, 2015
…t interface (patchset #1 id:1 of https://codereview.chromium.org/1118473003/) Reason for revert: This clearly needs to be the other way around. Imagine that those start / stop actions are async actions, ala promises. You expect to get the result at the caller instead of storing plumbing the success / error in the the call site from the client post-factum. Original issue's description: > Remove callback in TracingManager.start(), let it use client interface > > BUG= > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194737 TBR=yurys@chromium.org,caseq@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Review URL: https://codereview.chromium.org/1117973002 git-svn-id: svn://svn.chromium.org/blink/trunk@194745 bbb929c8-8fbe-4397-9dbb-9b2b20218538
jtg-gg
pushed a commit
that referenced
this pull request
Jul 31, 2015
#1 id:1 of https://codereview.chromium.org/1114103002/) Reason for revert: This removed the overview header along with the labels. Original issue's description: > DevTools: Fix black background on network overview. > > BUG=474174 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194765 TBR=yurys@chromium.org,alph@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=474174 Review URL: https://codereview.chromium.org/1120793002 git-svn-id: svn://svn.chromium.org/blink/trunk@194771 bbb929c8-8fbe-4397-9dbb-9b2b20218538
jtg-gg
pushed a commit
that referenced
this pull request
Jul 31, 2015
…ng (patchset #1 id:1 of https://codereview.chromium.org/1122483002/) Reason for revert: Didn't quite fix the issue: same failure appeared on the build bots. Reverting here to fix via TestExpectations instead. Original issue's description: > plugins/update-widgets-crash.html victim element goes missing > > The victim element to be removed is non-existant sometimes after the bugs > listed resolved. Workaround for now, by testing that the "victim" element > exists to avoid an exception, which causes extra test console output, and > fails the test. See issue 476590 #46 for a bot failure example. > > TBR=haraken@chromium.org > BUG=457054, 476590 > NOTRY=true > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194807 TBR=haraken@chromium.org,bbudge@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=457054, 476590 Review URL: https://codereview.chromium.org/1120963002 git-svn-id: svn://svn.chromium.org/blink/trunk@194809 bbb929c8-8fbe-4397-9dbb-9b2b20218538
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.