Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LPS-68125 Allow to use configuration to use user-agent #43

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

LPS-68125 Allow to use configuration to use user-agent #43

wants to merge 2 commits into from

Conversation

csierra
Copy link

@csierra csierra commented Sep 14, 2016 •
edited
Loading

we should document this as a breaking change also

@csierra csierra mentioned this pull request Sep 14, 2016
Closed
@juangon
Copy link
Owner

juangon commented Sep 14, 2016

@csierra as what I've talk to Nate and Chema this is a legacy feature not.used anymore.
Are we sure we need to keep this even as optional?

@liferay-continuous-integration
Copy link

Some tests FAILED!

Build Time: 2 hours 23 minutes 42 seconds

Base Branch:

Branch Name: master
Branch GIT ID: dcd37937c1cca7bdc2ca3bdb8990c72c5328644b

Job Summary:

For more details click here.

Failed Jobs:

  1. test-portal-acceptance-pullrequest(master)
    Job Results:

    73 Jobs Passed.
    10 Jobs Failed.

    Completed with the status of FAILURE.
  2. test-portal-acceptance-pullrequest-batch(master)/functional-tomcat8-mysql56-jdk8/17
    Job Results:

    31 Tests Passed.
    1 Test Failed.

    1. PoshiRunner.test[Forms#SubmitFormWithRequiredRepeatingTextField] - Forms#SubmitFormWithCustomTextContainingValidation - Forms#SubmitFormWithRequiredRepeatingTextField - Forms#SubmitFormWithTextField - Poshi Summary - Console Output
  3. test-portal-acceptance-pullrequest-batch(master)/integration-db2105-jdk8
    Build was aborted
  4. test-portal-acceptance-pullrequest-batch(master)/integration-hypersonic20-jdk8
    Job Results:

    4340 Tests Passed.
    81 Tests Failed.

    1. CounterLocalServiceTest.testConcurrentIncrement
    2. TestSuite.com.liferay.counter.service.persistence.test.CounterPersistenceTest
    3. TestSuite.com.liferay.portal.jmx.JMXWhiteboardTest
    4. ...

    Click here for more failures.

  5. test-portal-acceptance-pullrequest-batch(master)/integration-mysql56-jdk8
    Job Results:

    5360 Tests Passed.
    1 Test Failed.

    1. GroupLocalServiceTreeTest.testRebuildTree
  6. ...
For upstream results, click here.

@csierra
Copy link
Author

csierra commented Sep 15, 2016 •
edited
Loading

hey...
I don't know... I guess CacheFilter not only affects our developments but those of third parties. Although we don't use it anymore, if we simply disable it, we might be preventing others from generating different code for different browsers.
We can disable it by default but allow others to activate it if they need it (with all its consequences)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@csierra @juangon @liferay-continuous-integration