user-friendly config error message (#249) #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
| @@ -76,6 +76,19 @@ class server_helper { | |||
| } | |||
| // send error message to caller | |||
| throw JUBATUS_EXCEPTION(config_error); | |||
| } catch (const pfi::lang::parse_error& e) { | |||
| // exit immediately on JSON parse error with exit-code 1 | |||
There was a problem hiding this comment.
Currently,
- Syntax errors: print user-friendly message and call exit(1)
- Semantics errors: throw exception, prints stack trace and aborts
I think it is better to display user-friendly message in both cases.
How about changing the behaviour of the semantics errors to display user-friendly message too?
There was a problem hiding this comment.
Yes, I think so. I will change semantics errors behavior.
Furthermore, I think any user-operation errors should be reported by user-friendly message and exit(1).
Examples:
- Currently, when user start servers with same port, server throws exception and aborts.
There was a problem hiding this comment.
Agree! So,
- let's fix JSON syntax/semantic error messages in this issue, and
- raise new issue for refactoring to solve exit()ing in everywhere
There was a problem hiding this comment.
Umm... jsonconfig semantics errors (exceptions) are confused:
- jsonconfig::config_error exception classes are defined but used
- config semantics errors are reported by jubatus::config_exception, fv_converter::converter_exception, jubatus::unsupported_method ... and more???
y-oda-oni-juba
added a commit
that referenced
this pull request
Apr 18, 2013
user-friendly config error message (#249)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
modify jubaservers and jubaconfig json-config parse error like this:
jubaservers exit immediately with exit-code 1 on json-config parse error.