better spanning of ANSI control sequences from when finding graphemes #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
filter out `\ESC` graphemes when calculating length for column alignment
|
haskeline master (v0.8.0.0 wip) builds ok, but doesn't merge cleanly with my rendering fixes. |
…pletions One failing test, but guessing don't care: | ### Failure in: 0:interaction:4:history encoding:2 | tests/RunTTY.hs:106 | expected: ["abc??x?x?"] | but got: ["abc\206\177\239\191\189x\239\191\189x\239\191\189"] | Cases: 26 Tried: 26 Errors: 0 Failures: 1
aryairani
pushed a commit
to unisonweb/unison
that referenced
this pull request
Jun 15, 2022
resolves #1836 closes haskell/haskeline#115
|
I guess this has been resolved independently. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #114, I added a more detailed span for ANSI sequences, based on a definition from Wikipedia. :)
So this will look for ANSI control sequences (not just those ending in
'\STX') when grouping characters into graphemes, and then filters out'\ESC'graphemes when calculating length for column alignment.base:
PR:
What do you think? Thanks!