-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose internals #121
base: master
Are you sure you want to change the base?
Expose internals #121
Conversation
Exposing these modules only under System.Console.Haskeline.Internal implies that they have an unstable API that can be expected to break compatibility even between minor versions of Haskeline. Is this API not stable enough to retain compatibility for most or all of this functionality across minor versions, and simply bump a major version if any of these change later? |
I don’t know how stable they are, but this sort of thing is |
I've actually came back here to see this pull request to my surprise. I've tested this pull request and it would totally help outsiders to use the API in order to write a widget like the Brick <-> Haskeline widget. Would it be possible to merge this and if not give a hint what would need to happen to expose some of the internals like in this pull request? |
@judah ping. What do you think about this PR? It would be very helpful for purebred and other brick-based terminal programs. |
Also maybe we can add a warning notice like the ByteString package's
|
Fixes #118.
This exposes what you need to write your own backend, as shown by haskeline-brick. Please squash this if it gets merged!