Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Derive MonadBase instance for InputT #40

Closed
wants to merge 1 commit into from

Conversation

mitchellwrosen
Copy link

@mitchellwrosen mitchellwrosen commented May 16, 2016

This change is Reviewable

@judah
Copy link
Collaborator

judah commented May 16, 2016

Thanks for the patch.

I'm generally conservative about these sorts of changes because haskeline is a dependency of ghc, so any dependencies of haskeline become dependencies of ghc. See also a similar discussion in #24 about making haskeline depend on the "exceptions" package. If you can get consensus from the ghc-devs about depending on making such a package a boot requirement, then I'd be fine with adding the dependency.

In the meantime, maybe it's worth making an intermediate package with the orphan instance? Is that feasible using Control.Monad.Base.liftBaseDefault?

@mitchellwrosen
Copy link
Author

Ah, I didn't realize this is a dependency of GHC! For now, I'll just add an orphan instance in my app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants