Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSRV #143

Closed
arnaudpoullet-dkt opened this issue May 18, 2022 · 1 comment
Closed

MSRV #143

arnaudpoullet-dkt opened this issue May 18, 2022 · 1 comment

Comments

@arnaudpoullet-dkt
Copy link

First of all thanks for the library, I like its simple syntax!

On rustc 1.60 I have no issues, but any version below (I tried 1.55 -> 1.59) doesn't seem to build on my computer or in our CI. This is a bit blocking for us, because we can't change the version of rustc in our CI right now.

Nevertheless, I think the MSRV should be displayed in the doc or the README if it is indeed 1.60.

@juhaku
Copy link
Owner

juhaku commented May 18, 2022

Good to hear its been useful :) And unfortunate that the Rust version is getting on a way.

Yes the minimum supported rust version is 1.60, It actually is there at the README.md in form of a tag right under the headline. But it indeed is not super clear about it actually. I could make it more obvious though.

The code actually works on 1.56 and is build with the syntax supporting 1.56, But was recently bumped up the 1.60 just because Rust newly introduced dependency and feature naming strategy what came available at that point of time. All versions pre 1.0.0 supports Rust version 1.56.

@juhaku juhaku closed this as completed May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants